Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastfetch: 2.8.5 -> 2.8.6 #291876

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fastfetch: 2.8.5 -> 2.8.6 #291876

merged 1 commit into from
Feb 27, 2024

Conversation

iynaix
Copy link
Contributor

@iynaix iynaix commented Feb 27, 2024

Changelog: https://github.com/fastfetch-cli/fastfetch/blob/2.8.6/CHANGELOG.md#286
Diff: fastfetch-cli/fastfetch@2.8.5...2.8.6

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@khaneliman
Copy link
Contributor

Result of nixpkgs-review pr 291876 run on x86_64-linux 1

2 packages built:
  • fastfetch
  • fastfetch.man

Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just calling out for anyone who stumbles across breaking change from this update.

Due to newly introduced configs, JSONC option { "temperatureUnit": "C" } has been changed to { "temp": { "unit": "C" } }

Copy link
Contributor

@Gerg-L Gerg-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gerg-L Gerg-L added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Feb 27, 2024
@sikmir sikmir merged commit 94e3ac7 into NixOS:master Feb 27, 2024
28 of 29 checks passed
@iynaix iynaix deleted the bump-fastfetch branch February 28, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants