Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

av1an: init at 0.4.2 #292948

Merged
merged 1 commit into from
Jul 24, 2024
Merged

av1an: init at 0.4.2 #292948

merged 1 commit into from
Jul 24, 2024

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Mar 3, 2024

Description of changes

av1an a cross-platform command-line AV1 / VP9 / HEVC / H264 encoding framework with per scene quality encoding

Fixes #255427

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 3, 2024
pkgs/by-name/av/av1an-unwrapped/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/av/av1an/package.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Mar 5, 2024
@getchoo
Copy link
Member Author

getchoo commented Mar 10, 2024

@ofborg eval

@justinlime
Copy link
Member

Builds and runs great, closes #255427

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 29, 2024
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels May 29, 2024
pkgs/by-name/av/av1an-unwrapped/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/av/av1an-unwrapped/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/av/av1an-unwrapped/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/av/av1an/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/av/av1an/package.nix Outdated Show resolved Hide resolved
@eclairevoyant eclairevoyant removed the ofborg-internal-error Ofborg encountered an error label May 30, 2024
Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break overrides, hence needs fixing.
tracking issue: #312345

pkgs/by-name/av/av1an-unwrapped/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/av/av1an-unwrapped/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/av/av1an-unwrapped/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/av/av1an-unwrapped/package.nix Outdated Show resolved Hide resolved
@eclairevoyant eclairevoyant dismissed their stale review June 12, 2024 23:58

changes addressed

@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jun 26, 2024
@xescure
Copy link

xescure commented Jul 21, 2024

I'm not deeply familiar with the nixpkgs merge process. What's blocking this one?

@Aleksanaa Aleksanaa merged commit ea82a47 into NixOS:master Jul 24, 2024
25 checks passed
@getchoo getchoo deleted the pkgs/av1an/init branch July 24, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: av1an
8 participants