Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql-workbench: fix build #294086

Merged
merged 1 commit into from
Mar 7, 2024
Merged

mysql-workbench: fix build #294086

merged 1 commit into from
Mar 7, 2024

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Mar 7, 2024

Description of changes

Closes #294060

Because of a recent change to how antlr4_12.jarLocation is set we can no longer assume the filename for the jar file (it's now a store path).
To fix this I disabled the directory search logic, and hardcoded a different cmake variable instead. This is much more robust than before.

Another small change I made was that I merged preConfigure into postPatch

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 7, 2024
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 7, 2024
@drupol drupol merged commit e7416be into NixOS:master Mar 7, 2024
31 of 32 checks passed
@katrinafyi
Copy link
Member

Sorry for the trouble! It's good to see this was fixed quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: mysql-workbench-8.0.36
4 participants