minigalaxy: 1.2.2 -> 1.3.0

[ozkutuk]

Description of changes

https://github.com/sharkwouter/minigalaxy/blob/1.2.6/CHANGELOG.md

Supersedes #282594, adds the missing runtime dependency.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[quantenzitrone]

Result of nixpkgs-review pr 294275 run on x86_64-linux 1

2 packages built:

• minigalaxy
• minigalaxy.dist

[quantenzitrone]

I cannot get the app to run properly, starting it just shows me a black box with a title bar and another small black box which is probably supposed to be the login window.

[ozkutuk]

I cannot get the app to run properly, starting it just shows me a black box with a title bar and another small black box which is probably supposed to be the login window.

Interesting, I don't really know what to say apart from "it works for me". I am on KDE Plasma 6.0.3 with Wayland (although it worked on when I was on 5 as well). Have version 1.2.2 been working for you?

[quantenzitrone]

version 1.2.2 works and after logging in in version 1.2.2, 1.2.6 works as well, but the login window doesn't work in 1.2.6 and before logging in, the main window is just black (black due to my gtk theming probably).

so tldr only login does not work in 1.2.6

[ozkutuk]

Unfortunately, I can't replicate the issue. I have logged out of my account, and in addition removed the following directories just in case:

.config/minigalaxy/
.cache/minigalaxy/
.cache/.minigalaxy-wrapped/
.local/share/.minigalaxy-wrapped/

Still, when I open up minigalaxy for the first time, I am greeted with the login prompt as usual:

[quantenzitrone]

with v1.2.6:

with v.1.2.2:

I ran them both with env -i WAYLAND_DISPLAY=$WAYLAND_DISPLAY DISPLAY=$DISPLAY LOCALE_ARCHIVE=$LOCALE_ARCHIVE (-i removes any environment variables, but some are still needed so i re-add them) to remove as much impurities as possible. I don't really know what else to do.

[ozkutuk]

I ran them both with env -i WAYLAND_DISPLAY=$WAYLAND_DISPLAY DISPLAY=$DISPLAY LOCALE_ARCHIVE=$LOCALE_ARCHIVE (-i removes any environment variables, but some are still needed so i re-add them) to remove as much impurities as possible.

Are those two environment variables enough for you? When I try to run as such I get the following error:

$ env -i WAYLAND_DISPLAY=$WAYLAND_DISPLAY DISPLAY=$DISPLAY LOCALE_ARCHIVE=$LOCALE_ARCHIVE ./result/bin/minigalaxy
Authorization required, but no authorization protocol specified

Authorization required, but no authorization protocol specified


(.minigalaxy-wrapped:38780): Gtk-ERROR **: 00:30:46.211: Can't create a GtkStyleContext without a display connection

[quantenzitrone]

on Xorg i need XAUTHORITY instead of WAYLAND_DISPLAY

but when i tried it just now, the login page doesn't load on either versions

[SuperSandro2000]

I've took the freedom to push the 1.3.0 update onto this PR and cleanup the dependencies a bit.

[ozkutuk]

@SuperSandro2000 I was planning to test if minigalaxy is affected by #341219, but I now realize I can't actually get minigalaxy on master branch working on my machine. I am experiencing the same blank login screen issues as reported by @quantenzitrone. A workaround is suggested in the issue tracker of minigalaxy (sharkwouter/minigalaxy#584 (comment)), but it doesn't work for me either. Can you confirm that minigalaxy@master works for you when you remove the files I listed in #294275 (comment)?

[SuperSandro2000]

I tested minigalaxy on another machine and it just works as expected but I am on wayland.