rocmPackages: extend ISA compatibility #298388

GZGavinZhao · 2024-03-23T15:46:46Z

rocmPackages: extend rocm-runtime ISA compatibility
rocmPackages: extend clr ISA compatibility
rocmPackages: extend tensile ISA compatibility
rocmPackages: extend rocblas ISA compatibility
rocmPackages: extend miopen ISA compatibility

Description of changes

This will eliminate the need for users to use HSA_OVERRIDE_GFX_VERSION to emulate their GPUs as a supported GPU model.

For more info, see this mailing thread.

Things done

Add a 👍 reaction to pull requests you find important.

mschwaig · 2024-03-23T16:50:39Z

I think having that artificial barrier removed is a great change.

I just want to give you a heads up after quickly looking over that linked email:

It seems those patches are originally provided as git commits. Unless they need to be adapted somehow form the original commits, it would be better to integrate them by using fetchpatch instead of checking them in, like you can see for example in this change : 9a4f48b

GZGavinZhao · 2024-03-24T00:06:36Z

@mschwaig Updated. Thank you for your comment!

GZGavinZhao · 2024-03-24T00:07:05Z

I will leave nixpkgs-review running through the night, and if nothing fails I'll rebase the commits and mark this as ready for review tomorrow.

GZGavinZhao · 2024-03-24T19:42:58Z

Well I guess that had to be 2 nights because it ran out of space building rocblas... Going to finish the rest tonight and hopefully I can update the PR tomorrow.

mschwaig · 2024-03-28T11:18:47Z

Going by the output of nixpkgs-review it seems like rocblas is still not building yet.

Result of nixpkgs-review pr 298388 run on x86_64-linux 1

14 packages marked as broken and skipped:

rocmPackages.llvm.flang
rocmPackages.llvm.flang.doc
rocmPackages.llvm.flang.info
rocmPackages.llvm.flang.man
rocmPackages.migraphx
rocmPackages.rdc
rocmPackages.rdc.doc
rocmPackages_6.llvm.flang
rocmPackages_6.llvm.flang.doc
rocmPackages_6.llvm.flang.info
rocmPackages_6.llvm.flang.man
rocmPackages_6.migraphx
rocmPackages_6.rdc
rocmPackages_6.rdc.doc

6 packages failed to build:

rocmPackages.hipblas (rocmPackages_6.hipblas)
rocmPackages.hipsolver (rocmPackages_6.hipsolver)
rocmPackages.miopen (rocmPackages.miopen-hip ,rocmPackages_6.miopen ,rocmPackages_6.miopen-hip)
rocmPackages.rocalution (rocmPackages_6.rocalution)
rocmPackages.rocblas (rocmPackages_6.rocblas)
rocmPackages.rocsolver (rocmPackages_6.rocsolver)

34 packages built:

blender-hip
rocmPackages.clr (rocmPackages_6.clr)
rocmPackages.clr.icd (rocmPackages_6.clr.icd)
rocmPackages.composable_kernel (rocmPackages_6.composable_kernel)
rocmPackages.hipcub (rocmPackages_6.hipcub)
rocmPackages.hipfft (rocmPackages_6.hipfft)
rocmPackages.hiprand (rocmPackages.rocrand ,rocmPackages_6.hiprand ,rocmPackages_6.rocrand)
rocmPackages.hipsparse (rocmPackages_6.hipsparse)
rocmPackages.llvm.mlir (rocmPackages_6.llvm.mlir)
rocmPackages.llvm.openmp (rocmPackages_6.llvm.openmp)
rocmPackages.llvm.openmp.doc (rocmPackages_6.llvm.openmp.doc)
rocmPackages.llvm.openmp.info (rocmPackages_6.llvm.openmp.info)
rocmPackages.llvm.openmp.man (rocmPackages_6.llvm.openmp.man)
rocmPackages.rccl (rocmPackages_6.rccl)
rocmPackages.rocdbgapi (rocmPackages_6.rocdbgapi)
rocmPackages.rocdbgapi.doc (rocmPackages_6.rocdbgapi.doc)
rocmPackages.rocfft (rocmPackages_6.rocfft)
rocmPackages.rocm-runtime (rocmPackages_6.rocm-runtime)
rocmPackages.rocminfo (rocmPackages_6.rocminfo)
rocmPackages.rocmlir (rocmPackages_6.rocmlir)
rocmPackages.rocmlir-rock (rocmPackages_6.rocmlir-rock)
rocmPackages.rocmlir.external (rocmPackages_6.rocmlir.external)
rocmPackages.rocprim (rocmPackages_6.rocprim)
rocmPackages.rocprofiler (rocmPackages_6.rocprofiler)
rocmPackages.rocr-debug-agent (rocmPackages_6.rocr-debug-agent)
rocmPackages.rocsparse (rocmPackages_6.rocsparse)
rocmPackages.rocthrust (rocmPackages_6.rocthrust)
rocmPackages.roctracer (rocmPackages_6.roctracer)
rocmPackages.rocwmma (rocmPackages_6.rocwmma)
rocmPackages.rpp (rocmPackages.rpp-hip ,rocmPackages_6.rpp ,rocmPackages_6.rpp-hip)
rocmPackages.rpp-cpu (rocmPackages_6.rpp-cpu)
rocmPackages.rpp-opencl (rocmPackages_6.rpp-opencl)
rocmPackages.tensile (rocmPackages_6.tensile)
rocmPackages.tensile.dist (rocmPackages_6.tensile.dist)

Here is the build log:

@nix { "action": "setPhase", "phase": "unpackPhase" }
Running phase: unpackPhase
unpacking source archive /nix/store/ihrai11dd7zmmvj6j9g1kyj4337f85hh-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: patchPhase
applying patch /nix/store/04x9sfq554jgzhafdkpyznpk0azglwp0-Extend-rocBLAS-HIP-ISA-compatibility.patch
patching file library/src/handle.cpp
patching file library/src/rocblas_auxiliary.cpp
patching file library/src/tensile_host.cpp
ln: failed to create symbolic link 'build/Tensile/library/TensileLibrary.dat': File exists
/nix/store/hylcibqj87y8flsj51d2dpc7fiy6g1gx-stdenv-linux/setup: line 131: pop_var_context: head of shell_variables not a function context

Did you manage to run nixpkgs-review or are you having trouble with it?
My own experience is that ROCm is quite a pain to build with its huge hardware requirements.

GZGavinZhao · 2024-03-28T13:39:35Z

@mschwaig Thank you for the run! I haven't run nixpkgs-review yet because I'm still fixing rocblas. I realized I could set gpuTargets to only my GPU and I had been doing that to reduce the build time/memory requirement.

I had a fix for rocBLAS but it was really messy. I think I figured out a clean solution that requires just one short patch and no more postPatch. Currently building locally to verify.

GZGavinZhao · 2024-03-28T14:04:04Z

Quick question: I want to test rocBLAS through llama.cpp. How do I build a llama-cpp that has rocmSupport set to true?

mschwaig · 2024-03-28T14:09:51Z

Quick question: I want to test rocBLAS through llama.cpp. How do I build a llama-cpp that has rocmSupport set to true?

Should be llama-cpp.override { rocmSupport = true; }.

That works as part of some shell or system config. I don't know by without looking it up myself how to do it directly on the command line.
If you do not want touch some file to do this, you can also use the nix repl:

~/nixpkgs (fix-torch-with-rocm) [1]> nix repl
Welcome to Nix 2.18.1. Type :? for help.

nix-repl> :lf .
nix-repl> legacyPackages.x86_64-linux.llama-cpp.override { rocmSupport = true; }
«derivation /nix/store/p3743v86jviafpvgi53nwrs2bc3gzppn-llama-cpp-2481.drv»

nix-repl> :b legacyPackages.x86_64-linux.llama-cpp.override { rocmSupport = true; }

GZGavinZhao · 2024-03-28T23:39:58Z

Hi @mschwaig would you mind running nixpkgs-review on your end? rocblas now compiles fine, but for some reason even 64GB of RAM is not enough to run nixpkgs-review and I still frequently get out-of-disk-space errors :(

mschwaig · 2024-03-29T00:21:22Z

Hi @mschwaig would you mind running nixpkgs-review on your end? rocblas now compiles fine, but for some reason even 64GB of RAM is not enough to run nixpkgs-review and I still frequently get out-of-disk-space errors :(

Great to hear that it compiles.

I'm running nixpkgs-review now and I will post the results when it completes.

Tungsten842 · 2024-03-29T09:32:56Z

I was reading the llvm documentation for the upcoming generic targets and it doesn't look like that this patch will always work, for example:

It looks like that some targets do not support some instructions, so they are not really compatible. So for example for rocblas with this patch if you are using a gfx1012 by default you will be using gfx1010 code, that includes some instructions that are not supported by gfx1012. It looks like this might cause some problems.

mschwaig · 2024-03-29T12:21:41Z

Result of nixpkgs-review pr 298388 run on x86_64-linux 1

14 packages marked as broken and skipped:

rocmPackages.llvm.flang
rocmPackages.llvm.flang.doc
rocmPackages.llvm.flang.info
rocmPackages.llvm.flang.man
rocmPackages.migraphx
rocmPackages.rdc
rocmPackages.rdc.doc
rocmPackages_6.llvm.flang
rocmPackages_6.llvm.flang.doc
rocmPackages_6.llvm.flang.info
rocmPackages_6.llvm.flang.man
rocmPackages_6.migraphx
rocmPackages_6.rdc
rocmPackages_6.rdc.doc

5 packages failed to build:

rocmPackages.hipblas (rocmPackages_6.hipblas)
rocmPackages.hipsolver (rocmPackages_6.hipsolver)
rocmPackages.miopen (rocmPackages.miopen-hip ,rocmPackages_6.miopen ,rocmPackages_6.miopen-hip)
rocmPackages.rocalution (rocmPackages_6.rocalution)
rocmPackages.rocsolver (rocmPackages_6.rocsolver)

35 packages built:

blender-hip
rocmPackages.clr (rocmPackages_6.clr)
rocmPackages.clr.icd (rocmPackages_6.clr.icd)
rocmPackages.composable_kernel (rocmPackages_6.composable_kernel)
rocmPackages.hipcub (rocmPackages_6.hipcub)
rocmPackages.hipfft (rocmPackages_6.hipfft)
rocmPackages.hiprand (rocmPackages.rocrand ,rocmPackages_6.hiprand ,rocmPackages_6.rocrand)
rocmPackages.hipsparse (rocmPackages_6.hipsparse)
rocmPackages.llvm.mlir (rocmPackages_6.llvm.mlir)
rocmPackages.llvm.openmp (rocmPackages_6.llvm.openmp)
rocmPackages.llvm.openmp.doc (rocmPackages_6.llvm.openmp.doc)
rocmPackages.llvm.openmp.info (rocmPackages_6.llvm.openmp.info)
rocmPackages.llvm.openmp.man (rocmPackages_6.llvm.openmp.man)
rocmPackages.rccl (rocmPackages_6.rccl)
rocmPackages.rocblas (rocmPackages_6.rocblas)
rocmPackages.rocdbgapi (rocmPackages_6.rocdbgapi)
rocmPackages.rocdbgapi.doc (rocmPackages_6.rocdbgapi.doc)
rocmPackages.rocfft (rocmPackages_6.rocfft)
rocmPackages.rocm-runtime (rocmPackages_6.rocm-runtime)
rocmPackages.rocminfo (rocmPackages_6.rocminfo)
rocmPackages.rocmlir (rocmPackages_6.rocmlir)
rocmPackages.rocmlir-rock (rocmPackages_6.rocmlir-rock)
rocmPackages.rocmlir.external (rocmPackages_6.rocmlir.external)
rocmPackages.rocprim (rocmPackages_6.rocprim)
rocmPackages.rocprofiler (rocmPackages_6.rocprofiler)
rocmPackages.rocr-debug-agent (rocmPackages_6.rocr-debug-agent)
rocmPackages.rocsparse (rocmPackages_6.rocsparse)
rocmPackages.rocthrust (rocmPackages_6.rocthrust)
rocmPackages.roctracer (rocmPackages_6.roctracer)
rocmPackages.rocwmma (rocmPackages_6.rocwmma)
rocmPackages.rpp (rocmPackages.rpp-hip ,rocmPackages_6.rpp ,rocmPackages_6.rpp-hip)
rocmPackages.rpp-cpu (rocmPackages_6.rpp-cpu)
rocmPackages.rpp-opencl (rocmPackages_6.rpp-opencl)
rocmPackages.tensile (rocmPackages_6.tensile)
rocmPackages.tensile.dist (rocmPackages_6.tensile.dist)

These are the logs of the failing packages:
rocmPackages.rocsolver.log
rocmPackages.rocalution.log
rocmPackages.miopen.log

The logs for hipblas and hipsolver were empty since their dependencies failed to build.

GZGavinZhao · 2024-03-29T14:49:44Z

Hi @Tungsten842, I believe it's actually the reverse. The document is saying that because we're compiling against gfx1010, when you're running an executable compiled against gfx1010 on gfx1012 hardware, the instruction v_dot4_i32_i8 would not be available for you to use (the instruction would work properly if you try to call it, but your executable would never use this instruction) since the compiler has to assume you may be running on gfx1010. For example, you can see from the gfx1010 instruction docs that v_dot4_i32_i8 is not present, but this instruction is present in the gfx1011/gfx1012 instruction docs.

Therefore, gfx1010 is indeed the greatest common denominator for RDNA1 GPUs and all RDNA1 GPUs can use gfx1010 instructions as the basis ;)

GZGavinZhao · 2024-03-29T14:53:33Z

@mschwaig I believe I have fixed the issue (the header file rocblas.h is now being installed properly). Would you mind running nixpkgs-review when you get a chance? Thanks!

Tungsten842 · 2024-03-29T16:01:17Z

Hi @Tungsten842, I believe it's actually the reverse. The document is saying that because we're compiling against gfx1010, when you're running an executable compiled against gfx1010 on gfx1012 hardware, the instruction v_dot4_i32_i8 would not be available for you to use (the instruction would work properly if you try to call it, but your executable would never use this instruction) since the compiler has to assume you may be running on gfx1010. For example, you can see from the gfx1010 instruction docs that v_dot4_i32_i8 is not present, but this instruction is present in the gfx1011/gfx1012 instruction docs.

Therefore, gfx1010 is indeed the greatest common denominator for RDNA1 GPUs and all RDNA1 GPUs can use gfx1010 instructions as the basis ;)

Makes sense. But there is still one problem, it looks like that gfx900 supports some v_mad_mix instructions. But (gfx906, gfx904...) do not.
https://llvm.org/docs/AMDGPU/AMDGPUAsmGFX900.html
https://llvm.org/docs/AMDGPU/AMDGPUAsmGFX904.html
https://llvm.org/docs/AMDGPU/AMDGPUAsmGFX906.html
Also gfx1100 seems to have more VGPRs than other targets, not sure about the impact of this: https://reviews.llvm.org/D134522.

GZGavinZhao · 2024-03-29T16:17:48Z

@Tungsten842 You're right, though this PR doesn't make those changes, only the following:

gfx902, gfx909, gfx90c -> gfx900
gfx101* -> gfx1010
gfx103* -> gfx1030

So I believe we should be in the safe zone.

Signed-off-by: Gavin Zhao <[email protected]>

…cblas Signed-off-by: Gavin Zhao <[email protected]>

Signed-off-by: Gavin Zhao <[email protected]>

GZGavinZhao · 2024-04-25T02:24:35Z

@mschwaig Updated according to 89ab15f

cgmb · 2024-04-25T04:14:36Z

@mschwaig Updated according to 89ab15f

You've already patched rocBLAS to run gfx1010 kernels on gfx1012 hardware, so you can further reduce the size by dropping gfx1012 from that list.

mschwaig · 2024-04-25T07:26:37Z

@mschwaig Updated according to 89ab15f

Great! I already ran nixpkgs-review again with that change.

Result of nixpkgs-review run on x86_64-linux 1

10 packages marked as broken and skipped:

rocmPackages.llvm.flang
rocmPackages.llvm.flang.doc
rocmPackages.llvm.flang.info
rocmPackages.llvm.flang.man
rocmPackages.migraphx
rocmPackages.mivisionx
rocmPackages.mivisionx-cpu
rocmPackages.mivisionx-hip
rocmPackages.rdc
rocmPackages.rdc.doc

42 packages built:

blender-hip
rocmPackages.clr
rocmPackages.clr.icd
rocmPackages.composable_kernel
rocmPackages.hipblas
rocmPackages.hipcub
rocmPackages.hipfft
rocmPackages.hiprand
rocmPackages.hipsolver
rocmPackages.hipsparse
rocmPackages.llvm.mlir
rocmPackages.llvm.openmp
rocmPackages.llvm.openmp.doc
rocmPackages.llvm.openmp.info
rocmPackages.llvm.openmp.man
rocmPackages.miopen
rocmPackages.rccl
rocmPackages.rocalution
rocmPackages.rocblas
rocmPackages.rocdbgapi
rocmPackages.rocdbgapi.doc
rocmPackages.rocfft
rocmPackages.rocm-runtime
rocmPackages.rocminfo
rocmPackages.rocmlir
rocmPackages.rocmlir-rock
rocmPackages.rocmlir.external
rocmPackages.rocprim
rocmPackages.rocprofiler
rocmPackages.rocr-debug-agent
rocmPackages.rocrand
rocmPackages.rocsolver
rocmPackages.rocsparse
rocmPackages.rocthrust
rocmPackages.roctracer
rocmPackages.rocwmma
rocmPackages.rpp (rocmPackages.rpp-hip)
rocmPackages.rpp-cpu
rocmPackages.rpp-opencl
rocmPackages.tensile
rocmPackages.tensile.dist
zluda

The sizes are looking good as well:

du -h --apparent-size --max-depth 0 */ | grep G
3.7G	rocmPackages.composable_kernel/
1.6G	rocmPackages.miopen/
2.7G	rocmPackages.rocblas/
2.1G	rocmPackages.rocfft/
1.5G	rocmPackages.rocsolver/
1.2G	rocmPackages.rocsparse/

EDIT: llama-cpp also still runs on my RX 6600

…PU targets Signed-off-by: Gavin Zhao <[email protected]>

GZGavinZhao · 2024-04-25T13:56:22Z

You've already patched rocBLAS to run gfx1010 kernels on gfx1012 hardware, so you can further reduce the size by dropping gfx1012 from that list.

@cgmb Good call, thanks for pointing that out! I added gfx1012 to enable some optimization/instructions unavailable in gfx1010, but forgot my patch causes gfx101* GPUs to run as gfx1010, so building for gfx1012 is indeed useless for now 😅

@mschwaig I've removed gfx1012 just to save a bit more space. I don't think this requires another nixpkgs-review, so I think this is good for merge.

mschwaig

I used git range-diff master 062f308b9601f3fec588c8df0225eff7731f9834 32b9f37d57826364db0bc579ee75fa82af1fd623 to verify the contents of that last force-push and it looks good.

I would prefer if we had more info about what targets are missing in that list and why.
Maybe we should have a comment above that gpuTarget simply stating that
these are the defaults with gfx940 and gfx941 removed because they are early engineering samples and gfx1012 removed, because of the patch that makes it unused.

Otherwise it will be difficult to get this list right on future ROCm updates.

…uilt Signed-off-by: Gavin Zhao <[email protected]>

GZGavinZhao · 2024-04-25T15:48:50Z

@mschwaig Comments added. Ideally I think we should be using clr.gpuTargets in all places, though that would be for another PR. Solus uses gfx803;gfx900;gfx906;gfx908;gfx90a;gfx1010;gfx1030;gfx1100;gfx1101;gfx1102, and the only package we had to patch was composable_kernel.

ulrikstrid · 2024-04-25T16:59:47Z

I will take a closer look at this tomorrow and see if we can land this. Thanks a lot for working on this!

ulrikstrid · 2024-04-26T06:09:28Z

The changes looks good. I'm just running a last nixpkgs-review and then we can merge this.

Again thank you @GZGavinZhao and @mschwaig for making this happen!

GZGavinZhao force-pushed the rocm-gfx-compat branch 2 times, most recently from 1e0e3e3 to 82af478 Compare March 23, 2024 15:55

ofborg bot requested review from lovesegfault, Madouura, Flakebi and mschwaig March 23, 2024 16:11

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100 labels Mar 23, 2024

GZGavinZhao force-pushed the rocm-gfx-compat branch 3 times, most recently from 366adb5 to fa1628b Compare March 27, 2024 02:46

GZGavinZhao force-pushed the rocm-gfx-compat branch from 4798380 to 2c585f5 Compare March 28, 2024 23:41

GZGavinZhao force-pushed the rocm-gfx-compat branch from 2c585f5 to 13e1f01 Compare March 29, 2024 14:49

GZGavinZhao added 9 commits April 24, 2024 22:23

rocmPackages: extend miopen ISA compatibility

e240329

Signed-off-by: Gavin Zhao <[email protected]>

rocmPackages: respect NIX_BUILD_CORES and cleanup CMake options in ro…

e15c449

…cblas Signed-off-by: Gavin Zhao <[email protected]>

rocmPackages: cleanup and remove double building for rocblas

f4f68f4

Signed-off-by: Gavin Zhao <[email protected]>

rocmPackages: don't build arches in parallel in rccl

d276a67

Signed-off-by: Gavin Zhao <[email protected]>

rocmPackages: install headers correctly in rocblas

73e919d

Signed-off-by: Gavin Zhao <[email protected]>

rocmPackages: fix dependencies in rocblas

7ff6984

Signed-off-by: Gavin Zhao <[email protected]>

rocmPackages: fetch patches from Debian if possible

e30bae6

Signed-off-by: Gavin Zhao <[email protected]>

rocmPackages: add isa conversion patch in rocprim

45b3242

Signed-off-by: Gavin Zhao <[email protected]>

rocmPackages: no need to pass rocblas to itself

7bbde17

Signed-off-by: Gavin Zhao <[email protected]>

ofborg bot requested a review from mschwaig April 25, 2024 02:54

ofborg bot removed the 10.rebuild-darwin: 1 label Apr 25, 2024

rocmPackages.rocblas: do not build for gfx1012, gfx940, and gfx 941 G…

32b9f37

…PU targets Signed-off-by: Gavin Zhao <[email protected]>

GZGavinZhao force-pushed the rocm-gfx-compat branch from 062f308 to 32b9f37 Compare April 25, 2024 13:55

GZGavinZhao mentioned this pull request Apr 25, 2024

Regression in rocm 5.3 and newer for gfx1010 ROCm/ROCm#2527

Open

mschwaig approved these changes Apr 25, 2024

View reviewed changes

rocmPackages.rocblas: add comments about why some GPU archs are not b…

c3848d5

…uilt Signed-off-by: Gavin Zhao <[email protected]>

ofborg bot requested a review from mschwaig April 25, 2024 16:12

mschwaig approved these changes Apr 25, 2024

View reviewed changes

ulrikstrid approved these changes Apr 26, 2024

View reviewed changes

wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Apr 27, 2024

mschwaig mentioned this pull request Apr 28, 2024

Report outputs that are larger than Hydra's size limit Mic92/nixpkgs-review#398

Open

ulrikstrid merged commit cd711ad into NixOS:master Apr 29, 2024
27 of 28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rocmPackages: extend ISA compatibility #298388

rocmPackages: extend ISA compatibility #298388

GZGavinZhao commented Mar 23, 2024 •

edited

Loading

mschwaig commented Mar 23, 2024

GZGavinZhao commented Mar 24, 2024

GZGavinZhao commented Mar 24, 2024 •

edited

Loading

GZGavinZhao commented Mar 24, 2024

mschwaig commented Mar 28, 2024

GZGavinZhao commented Mar 28, 2024 •

edited

Loading

GZGavinZhao commented Mar 28, 2024

mschwaig commented Mar 28, 2024 •

edited

Loading

GZGavinZhao commented Mar 28, 2024

mschwaig commented Mar 29, 2024

Tungsten842 commented Mar 29, 2024

mschwaig commented Mar 29, 2024

GZGavinZhao commented Mar 29, 2024 •

edited

Loading

GZGavinZhao commented Mar 29, 2024

Tungsten842 commented Mar 29, 2024

GZGavinZhao commented Mar 29, 2024

GZGavinZhao commented Apr 25, 2024

cgmb commented Apr 25, 2024

mschwaig commented Apr 25, 2024 •

edited

Loading

GZGavinZhao commented Apr 25, 2024

mschwaig left a comment

GZGavinZhao commented Apr 25, 2024

ulrikstrid commented Apr 25, 2024

ulrikstrid commented Apr 26, 2024

rocmPackages: extend ISA compatibility #298388

rocmPackages: extend ISA compatibility #298388

Conversation

GZGavinZhao commented Mar 23, 2024 • edited Loading

Description of changes

Things done

mschwaig commented Mar 23, 2024

GZGavinZhao commented Mar 24, 2024

GZGavinZhao commented Mar 24, 2024 • edited Loading

GZGavinZhao commented Mar 24, 2024

mschwaig commented Mar 28, 2024

GZGavinZhao commented Mar 28, 2024 • edited Loading

GZGavinZhao commented Mar 28, 2024

mschwaig commented Mar 28, 2024 • edited Loading

GZGavinZhao commented Mar 28, 2024

mschwaig commented Mar 29, 2024

Tungsten842 commented Mar 29, 2024

mschwaig commented Mar 29, 2024

GZGavinZhao commented Mar 29, 2024 • edited Loading

GZGavinZhao commented Mar 29, 2024

Tungsten842 commented Mar 29, 2024

GZGavinZhao commented Mar 29, 2024

GZGavinZhao commented Apr 25, 2024

cgmb commented Apr 25, 2024

mschwaig commented Apr 25, 2024 • edited Loading

GZGavinZhao commented Apr 25, 2024

mschwaig left a comment

Choose a reason for hiding this comment

GZGavinZhao commented Apr 25, 2024

ulrikstrid commented Apr 25, 2024

ulrikstrid commented Apr 26, 2024

GZGavinZhao commented Mar 23, 2024 •

edited

Loading

GZGavinZhao commented Mar 24, 2024 •

edited

Loading

GZGavinZhao commented Mar 28, 2024 •

edited

Loading

mschwaig commented Mar 28, 2024 •

edited

Loading

GZGavinZhao commented Mar 29, 2024 •

edited

Loading

mschwaig commented Apr 25, 2024 •

edited

Loading