Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.ollama: init at 0.5.0 #298676

Closed
wants to merge 1 commit into from
Closed

Conversation

Kahlenden
Copy link

@Kahlenden Kahlenden commented Mar 24, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi !

Thanks for your contribution.

  1. Read the contributor guide (https://nix.dev/contributing/how-to-contribute.html) to learn how to format the PR title and commit log message
  2. I see that the node-packages.nix contains many package updates, is it intended ?

@Kahlenden Kahlenden changed the title Add nodePackages.ollama #298315 pkgs.nodePackages.ollama: init at 0.5.0 Mar 25, 2024
@abysssol abysssol changed the title pkgs.nodePackages.ollama: init at 0.5.0 nodePackages.ollama: init at 0.5.0 Jul 3, 2024
@abysssol abysssol linked an issue Jul 3, 2024 that may be closed by this pull request
@abysssol
Copy link
Contributor

abysssol commented Jul 3, 2024

What's the status of this pr? Are there any remaining blockers? From what I can see, it looks ready to merge.

@SuperSandro2000
Copy link
Member

We don't want to add new packages to nodePackages and it should be packaged separately. You seem to care for this PR. Could you open a PR for that?

@abysssol
Copy link
Contributor

abysssol commented Jul 3, 2024

We don't want to add new packages to nodePackages

Why? Could you point me to any relevant documentation/issues/etc?

Could you open a PR for that?

I would, but I don't know the process for creating node packages. Could you tell me where to start (ie documentation or existing example package). Nevermind, I finally found this.

@SuperSandro2000
Copy link
Member

Why? Could you point me to any relevant documentation/issues/etc?

see #229475

@abysssol
Copy link
Contributor

abysssol commented Jul 3, 2024

@SuperSandro2000 From what I can tell, ollama-js is just a library, which makes me wonder whether it should be packaged at all. From what I can tell, all node packages in nix have a cli or some interactive artifact; I'm not even sure how js libraries packaged in nix can be used, or if they can be at all. What do you think?

@Kahlenden Why do you want ollama-js to be packaged in nixpkgs? What use case does that enable for you, in what ways can it be used?

@SuperSandro2000
Copy link
Member

Good question. I do not know either. It could be that some program required it to be build or so but then it should be packaged there.

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: ollama-js
5 participants