-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodePackages.ollama: init at 0.5.0 #298676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi !
Thanks for your contribution.
- Read the contributor guide (https://nix.dev/contributing/how-to-contribute.html) to learn how to format the PR title and commit log message
- I see that the
node-packages.nix
contains many package updates, is it intended ?
3b71bb6
to
d513530
Compare
What's the status of this pr? Are there any remaining blockers? From what I can see, it looks ready to merge. |
We don't want to add new packages to nodePackages and it should be packaged separately. You seem to care for this PR. Could you open a PR for that? |
Why? Could you point me to any relevant documentation/issues/etc?
|
see #229475 |
@SuperSandro2000 From what I can tell, ollama-js is just a library, which makes me wonder whether it should be packaged at all. From what I can tell, all node packages in nix have a cli or some interactive artifact; I'm not even sure how js libraries packaged in nix can be used, or if they can be at all. What do you think? @Kahlenden Why do you want ollama-js to be packaged in nixpkgs? What use case does that enable for you, in what ways can it be used? |
Good question. I do not know either. It could be that some program required it to be build or so but then it should be packaged there. Closing |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.