Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/hyprland: add the correct user profile bin directory to systemd PATH #303174

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

JohnRTitor
Copy link
Contributor

@JohnRTitor JohnRTitor commented Apr 10, 2024

Description of changes

Minor bug fix patch on #298896.
%u modifier can be used to get the username in systemd config.
$USER environment variable expansion does not work without manually importing $USER into the systemd environment.
Should fix opening links in apps installed via home manager/user profile.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Pinging maintainer for review: @fufexan


Add a 👍 reaction to pull requests you find important.

@JohnRTitor JohnRTitor requested a review from fufexan April 10, 2024 18:34
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 10, 2024
@JohnRTitor
Copy link
Contributor Author

@ofborg eval

@cole-h
Copy link
Member

cole-h commented Apr 10, 2024

You'll want to rebase on the latest master -- there was an issue that broke ofborg's ability to evaluate Nixpkgs that has since been resolved. Sorry for the inconvenience!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 11, 2024
%u modifier can be used to get the username in systemd config
$USER var expansion does not work without manually importing $USER
Should fix opening links in home manager/user profile programs
@JohnRTitor
Copy link
Contributor Author

You'll want to rebase on the latest master -- there was an issue that broke ofborg's ability to evaluate Nixpkgs that has since been resolved. Sorry for the inconvenience!

Rebased. Thanks.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Apr 11, 2024
@JohnRTitor JohnRTitor changed the title nixos/hyprland: systemd.setPath - fix user profile bin directory nixos/hyprland: add the correct user profile bin directory to systemd PATH Apr 11, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 11, 2024
@JohnRTitor
Copy link
Contributor Author

JohnRTitor commented Apr 11, 2024

@Mic92 could you please review it? Minor bugfix. Should be merged before 24.05 feature freezes, else we'll have a half working option.

@wineee wineee merged commit 304c66c into NixOS:master Apr 13, 2024
25 checks passed
@JohnRTitor JohnRTitor deleted the hyprland-module branch April 13, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants