Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brainflow: init at 5.12.1 #303718

Closed
wants to merge 158 commits into from
Closed

brainflow: init at 5.12.1 #303718

wants to merge 158 commits into from

Conversation

Pandapip1
Copy link
Contributor

@Pandapip1 Pandapip1 commented Apr 12, 2024

Description of changes

Blocked by #303716

Closes #278412 (supersedes)

Closes #303517

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Pandapip1 Pandapip1 changed the title init brainflow at 5.12.1 brainflow: Init at 5.12.1 Apr 12, 2024
@Pandapip1
Copy link
Contributor Author

Pandapip1 commented Apr 12, 2024

FYI - the reason I'm using the wheel rather than building from source is because the build process isn't documented anywhere, and it's very nontrivial.

@Pandapip1
Copy link
Contributor Author

Pandapip1 commented Apr 15, 2024

I was able to find build instructions at https://brainflow.readthedocs.io/en/stable/BuildBrainFlow.html#linux

@Pandapip1 Pandapip1 changed the title brainflow: Init at 5.12.1 python3Packages.brainflow: Init at 5.12.1 Apr 16, 2024
@Pandapip1 Pandapip1 force-pushed the brainflow branch 2 times, most recently from 30b0277 to 5d7ca8c Compare May 1, 2024 21:02
@Pandapip1 Pandapip1 changed the title python3Packages.brainflow: Init at 5.12.1 python3Packages.brainflow: init 5.12.1 May 1, 2024
@Pandapip1 Pandapip1 force-pushed the brainflow branch 7 times, most recently from cae18dc to 0b125e6 Compare May 7, 2024 01:51
@Pandapip1 Pandapip1 changed the title python3Packages.brainflow: init 5.12.1 python3Packages.brainflow: init unstable-05-01-2024 May 7, 2024
@Pandapip1 Pandapip1 changed the title python3Packages.brainflow: init unstable-05-01-2024 python3Packages.brainflow: init unstable-2024-05-01 May 7, 2024
@ofborg ofborg bot requested a review from ziguana May 7, 2024 05:27
@Pandapip1 Pandapip1 marked this pull request as ready for review May 9, 2024 22:03
@Pandapip1
Copy link
Contributor Author

Pandapip1 commented Jul 4, 2024

Whoops. Guess I'll open a new PR...

Sorry for the ping guys. New PR is #324462

@Pandapip1 Pandapip1 closed this Jul 4, 2024
@Pandapip1 Pandapip1 deleted the brainflow branch July 4, 2024 02:48
@Pandapip1 Pandapip1 mentioned this pull request Jul 4, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: python311Packages.brainflow