dogedns: init at 0.2.6 #305139
Merged
dogedns: init at 0.2.6 #305139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
aktaboot
force-pushed
the
init-dogedns
branch
3 times, most recently
from
02fdbbf
to
5107bd3
Compare
Aleksanaa
reviewed
Apr 19, 2024
pkgs/top-level/all-packages.nix
Outdated
| @@ -7495,6 +7495,10 @@ with pkgs; | |||
| inherit (darwin.apple_sdk.frameworks) Security; | |||
| }; | |||
|
|
|||
| dogedns = callPackage ../by-name/do/dogedns/package.nix { | |||
| inherit (darwin.apple_sdk.frameworks) Security; | |||
There was a problem hiding this comment.
Maybe just add darwin to package input?
Aleksanaa
reviewed
Apr 19, 2024
Yes but not suitable for using alias, because this project only gets 18 stars and dogdns gets 5.8k. We can add something like |
aktaboot
force-pushed
the
init-dogedns
branch
2 times, most recently
from
ee1fa66
to
16c613b
Compare
|
thanks for the review @Aleksanaa, appreciate it :) |
ofborg
bot
added
the
11.by: package-maintainer
aktaboot
changed the title
Aleksanaa
reviewed
Apr 20, 2024
Aleksanaa
reviewed
Apr 20, 2024
pkgs/by-name/do/dogedns/Cargo.lock
Outdated
pkgs/by-name/do/dogedns/package.nix
Outdated
| ./remove-date-info.patch | ||
| ]; | ||
|
|
||
| postInstall = '' |
There was a problem hiding this comment.
Would be better to put this after buildInputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds doge, a cli DNS client forked from dog which is no longer maintained!
@figsoda should dogdns be dropped in favor of this ? #141368
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.