immich-go: refactor linker data #305699
Closed
immich-go: refactor linker data #305699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3879 |
AndersonTorres
approved these changes
May 5, 2024
kai-tub
force-pushed
the
pkgs/immich-go/refactor
branch
from
4374acb
to
c88a39a
Compare
Follow upstream more closely and set `commit` and `date` metadata to avoid confusion. Co-authored-by: Anderson Torres <[email protected]>
kai-tub
force-pushed
the
pkgs/immich-go/refactor
branch
from
c88a39a
to
1f7b860
Compare
13 tasks
|
Was included in #313310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #303799, I would like to follow upstream more closely and set the
commitanddatelinker variables correctly. In contrast to pdfcpu, this isn't required by upstream, but the information is printed every time the binary is called and I would like to avoid any potential confusion of downstream users in this case.Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.