Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rPackages.psbcGroup: fixed build #307176

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

b-rodrigues
Copy link
Contributor

@b-rodrigues b-rodrigues commented Apr 27, 2024

Description of changes

Added gsl to buildinputs to fix build.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@b-rodrigues b-rodrigues requested a review from jbedo as a code owner April 27, 2024 10:13
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Apr 27, 2024
Copy link
Contributor

@Kupac Kupac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran an example. It took forever (not literally), and created a list with bunch of numbers. I say it works.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 28, 2024
@matthiasbeyer
Copy link
Contributor

Result of nixpkgs-review pr 307176 run on x86_64-linux 1

@wegank wegank merged commit 8285130 into NixOS:master May 2, 2024
23 of 24 checks passed
@b-rodrigues b-rodrigues deleted the fix_psbcGroup branch May 2, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants