Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: move packages maintained by lucperkins to pkgs/by-name #308863

Merged
merged 1 commit into from
May 6, 2024

Conversation

lucperkins
Copy link
Contributor

@lucperkins lucperkins commented May 3, 2024

Description of changes

This PR moves all of my contributed packages into by-name.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels May 3, 2024
@ofborg ofborg bot requested a review from amesgen May 3, 2024 19:33
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 3, 2024
Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (got pinged as I co-maintain wizer)

However, this shouldn't actually be necessary:

There’s no need to migrate existing packages to pkgs/by-name. That will be done automatically as the next and final step of RFC 140. See also the guide on manual pkgs/by-name migration.

https://discourse.nixos.org/t/ci-will-soon-enforce-pkgs-by-name-for-new-packages/38098

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels May 4, 2024
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reword to treewide: move packages maintained by lucperkins to pkgs/by-name

@lucperkins lucperkins changed the title Move lucperkins packages into by-name treewide: move packages maintained by lucperkins to pkgs/by-name May 6, 2024
@lucperkins
Copy link
Contributor Author

lucperkins commented May 6, 2024

@amesgen I was aware of this. I do, however, think that putting pre-by-name packages in by-name is beneficial to the project as it aids in discoverability and cuts down on clutter in all-packages.nix.

Ah, okay, I misread the first time. Feel free to close/reject as necessary. I don't think this PR hurts but if it muddies the water unnecessarily, happy to let it go.

Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@Aleksanaa Aleksanaa merged commit 97ae4fc into NixOS:master May 6, 2024
36 of 40 checks passed
@lucperkins lucperkins deleted the move-into-by-name branch May 20, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants