-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
po4a: 0.62 -> 0.71 #309008
po4a: 0.62 -> 0.71 #309008
Conversation
Cc: @marcusramberg |
@linsui Thanks for splitting up the commit, it makes it a lot easier to review :) |
Changes look good to me. I did try a nixpkgs-review; obviously it's a huge rebuild, but didn't spot anything new broken that wasn't already broken by itself. |
Since this is targeted to Under normal conditions it should be against |
Sorry, I'll rebase it to the staging branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Description of changes
I only tested that po4a itself work.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.