Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

po4a: 0.62 -> 0.71 #309008

Merged
merged 2 commits into from
May 5, 2024
Merged

po4a: 0.62 -> 0.71 #309008

merged 2 commits into from
May 5, 2024

Conversation

linsui
Copy link
Contributor

@linsui linsui commented May 4, 2024

Description of changes

I only tested that po4a itself work.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@linsui linsui mentioned this pull request May 4, 2024
13 tasks
@stigtsp
Copy link
Member

stigtsp commented May 4, 2024

Cc: @marcusramberg

@stigtsp stigtsp requested a review from marcusramberg May 4, 2024 08:53
@stigtsp
Copy link
Member

stigtsp commented May 4, 2024

@linsui Thanks for splitting up the commit, it makes it a lot easier to review :)

@marcusramberg
Copy link
Contributor

Changes look good to me. I did try a nixpkgs-review; obviously it's a huge rebuild, but didn't spot anything new broken that wasn't already broken by itself.

@stigtsp
Copy link
Member

stigtsp commented May 5, 2024

Since this is targeted to staging-next, is it related to #309297 by any chance?

Under normal conditions it should be against staging I believe.

@linsui
Copy link
Contributor Author

linsui commented May 5, 2024

Sorry, I'll rebase it to the staging branch.

@linsui linsui changed the base branch from staging-next to staging May 5, 2024 18:01
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stigtsp stigtsp merged commit 56d8e18 into NixOS:staging May 5, 2024
28 of 30 checks passed
@linsui linsui deleted the po4a branch May 6, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants