Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourcehut: Fix werkzueg dependency build #309325

Merged
merged 1 commit into from
May 7, 2024

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented May 5, 2024

Description of changes

With pytest 8, sourcehut fails to build due to the overridden werkzeug 2.3.8 version having a single failing test. The patch that this adds is from version 3.0.2, which applies cleanly. I've run the tests for sourcehut and they work fine.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@josephst
Copy link
Member

josephst commented May 7, 2024

lgtm 👍

Result of nixpkgs-review pr 309325 run on x86_64-linux 1

20 packages built:
  • sourcehut.buildsrht
  • sourcehut.buildsrht.dist
  • sourcehut.coresrht
  • sourcehut.coresrht.dist
  • sourcehut.gitsrht
  • sourcehut.gitsrht.dist
  • sourcehut.hgsrht
  • sourcehut.hgsrht.dist
  • sourcehut.hubsrht
  • sourcehut.hubsrht.dist
  • sourcehut.listssrht
  • sourcehut.listssrht.dist
  • sourcehut.mansrht
  • sourcehut.mansrht.dist
  • sourcehut.metasrht
  • sourcehut.metasrht.dist
  • sourcehut.pastesrht
  • sourcehut.pastesrht.dist
  • sourcehut.todosrht
  • sourcehut.todosrht.dist

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pyrox0 pyrox0 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 7, 2024
@mweinelt mweinelt merged commit 5744325 into NixOS:master May 7, 2024
23 checks passed
@pyrox0 pyrox0 mentioned this pull request May 9, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants