Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various python fixes ZHF-style. #309391

Merged
merged 10 commits into from
May 6, 2024
Merged

Various python fixes ZHF-style. #309391

merged 10 commits into from
May 6, 2024

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented May 5, 2024

Description of changes

Reduce build failures packages that I maintain.

#309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mweinelt mweinelt changed the title Various python fixxes ZHF-style. Various python fixes ZHF-style. May 5, 2024
@ofborg ofborg bot added 8.has: clean-up 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels May 5, 2024
@nbraud
Copy link
Contributor

nbraud commented May 6, 2024

Result of nixpkgs-review pr 309391 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • piper-train
  • piper-train.dist
  • tts
  • tts.dist
17 packages failed to build:
  • pianotrans
  • pianotrans.dist
  • pitivi
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python311Packages.librosa
  • python311Packages.librosa.dist
  • python311Packages.piano-transcription-inference
  • python311Packages.piano-transcription-inference.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python311Packages.tinygrad
  • python311Packages.tinygrad.dist
  • python311Packages.torch-audiomentations
  • python311Packages.torch-audiomentations.dist
  • python311Packages.torchlibrosa
  • python311Packages.torchlibrosa.dist
20 packages built:
  • ledfx
  • ledfx.dist
  • pretix
  • pretix.dist
  • python311Packages.faster-fifo
  • python311Packages.faster-fifo.dist
  • python311Packages.paypal-checkout-serversdk
  • python311Packages.paypal-checkout-serversdk.dist
  • python311Packages.paypalhttp
  • python311Packages.paypalhttp.dist
  • python311Packages.samplerate
  • python311Packages.samplerate.dist
  • python312Packages.faster-fifo
  • python312Packages.faster-fifo.dist
  • python312Packages.paypal-checkout-serversdk
  • python312Packages.paypal-checkout-serversdk.dist
  • python312Packages.paypalhttp
  • python312Packages.paypalhttp.dist
  • python312Packages.samplerate
  • python312Packages.samplerate.dist

Requires distutils.
@mweinelt mweinelt added the 0.kind: ZHF Fixes Fixes during the ZHF campaign label May 6, 2024
@mweinelt
Copy link
Member Author

mweinelt commented May 6, 2024

Result of nixpkgs-review pr 309391 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • piper-train
  • piper-train.dist
  • tts
  • tts.dist
8 packages failed to build:
  • python311Packages.cartopy
  • python311Packages.cartopy.dist
  • python311Packages.glueviz
  • python311Packages.glueviz.dist
  • python312Packages.cartopy
  • python312Packages.cartopy.dist
  • python312Packages.tinygrad
  • python312Packages.tinygrad.dist
83 packages built:
  • ledfx
  • ledfx.dist
  • pianotrans
  • pianotrans.dist
  • pitivi
  • pretix
  • pretix.dist
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python311Packages.coffea
  • python311Packages.coffea.dist
  • python311Packages.colorcet
  • python311Packages.colorcet.dist
  • python311Packages.dask-awkward
  • python311Packages.dask-awkward.dist
  • python311Packages.datashader
  • python311Packages.datashader.dist
  • python311Packages.faster-fifo
  • python311Packages.faster-fifo.dist
  • python311Packages.hist
  • python311Packages.hist.dist
  • python311Packages.holoviews
  • python311Packages.holoviews.dist
  • python311Packages.hvplot
  • python311Packages.hvplot.dist
  • python311Packages.intake
  • python311Packages.intake.dist
  • python311Packages.librosa
  • python311Packages.librosa.dist
  • python311Packages.mpl-scatter-density
  • python311Packages.mpl-scatter-density.dist
  • python311Packages.mplhep
  • python311Packages.mplhep.dist
  • python311Packages.nbsmoke
  • python311Packages.nbsmoke.dist
  • python311Packages.paypal-checkout-serversdk
  • python311Packages.paypal-checkout-serversdk.dist
  • python311Packages.paypalhttp
  • python311Packages.paypalhttp.dist
  • python311Packages.piano-transcription-inference
  • python311Packages.piano-transcription-inference.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python311Packages.pytest-mpl
  • python311Packages.pytest-mpl.dist
  • python311Packages.samplerate
  • python311Packages.samplerate.dist
  • python311Packages.tinygrad
  • python311Packages.tinygrad.dist
  • python311Packages.torch-audiomentations
  • python311Packages.torch-audiomentations.dist
  • python311Packages.torchlibrosa
  • python311Packages.torchlibrosa.dist
  • python312Packages.asteroid-filterbanks
  • python312Packages.asteroid-filterbanks.dist
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python312Packages.dask-awkward
  • python312Packages.dask-awkward.dist
  • python312Packages.faster-fifo
  • python312Packages.faster-fifo.dist
  • python312Packages.hist
  • python312Packages.hist.dist
  • python312Packages.librosa
  • python312Packages.librosa.dist
  • python312Packages.mpl-scatter-density
  • python312Packages.mpl-scatter-density.dist
  • python312Packages.mplhep
  • python312Packages.mplhep.dist
  • python312Packages.paypal-checkout-serversdk
  • python312Packages.paypal-checkout-serversdk.dist
  • python312Packages.paypalhttp
  • python312Packages.paypalhttp.dist
  • python312Packages.piano-transcription-inference
  • python312Packages.piano-transcription-inference.dist
  • python312Packages.pytest-mpl
  • python312Packages.pytest-mpl.dist
  • python312Packages.samplerate
  • python312Packages.samplerate.dist
  • python312Packages.torch-audiomentations
  • python312Packages.torch-audiomentations.dist
  • python312Packages.torchlibrosa
  • python312Packages.torchlibrosa.dist

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label May 6, 2024
Build requires distutils.
@mweinelt mweinelt merged commit e3f29be into NixOS:master May 6, 2024
6 of 7 checks passed
@mweinelt mweinelt deleted the do-things branch May 6, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the ZHF campaign 6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants