Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sirula: 1.0.0 -> 1.0.0-unstable-2023-09-02 #309535

Merged
merged 1 commit into from
May 6, 2024

Conversation

pluiedev
Copy link
Contributor

@pluiedev pluiedev commented May 6, 2024

Description of changes

While there was no release from the upstream, it's important for sirula to receive this update as it currently does not build with Rust 1.71 and above, due to a typo in one of its dependencies (see DorianRudolph/sirula#37).

This is part of the ongoing ZHF campaign for 24.05.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

While there was no release from the upstream, it's important for sirula
to receive this update as it currently does not build with Rust 1.71 and
above, due to a typo in one of its dependencies (see
DorianRudolph/sirula#37).
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 6, 2024
@wegank wegank merged commit ff66b79 into NixOS:master May 6, 2024
26 of 27 checks passed
@pluiedev pluiedev deleted the zhf-24.05/sirula branch May 6, 2024 12:43
@wegank wegank mentioned this pull request Jul 3, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants