Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.validator-collection: disable failing tests #309629

Merged
merged 1 commit into from
May 6, 2024

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 6, 2024

Description of changes

Fix build (https://hydra.nixos.org/build/258381058)

ZHF: #309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabaff fabaff added the 0.kind: ZHF Fixes Fixes during the ZHF campaign label May 6, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 6, 2024
@fabaff
Copy link
Member Author

fabaff commented May 6, 2024

Result of nixpkgs-review pr 309629 run on x86_64-linux 1

8 packages built:
  • python311Packages.mkdocs-rss-plugin
  • python311Packages.mkdocs-rss-plugin.dist
  • python311Packages.validator-collection
  • python311Packages.validator-collection.dist
  • python312Packages.mkdocs-rss-plugin
  • python312Packages.mkdocs-rss-plugin.dist
  • python312Packages.validator-collection
  • python312Packages.validator-collection.dist

@fabaff fabaff merged commit d791e7d into NixOS:master May 6, 2024
27 of 28 checks passed
@fabaff fabaff deleted the validator-collection-fix branch May 6, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the ZHF campaign 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant