Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qmenumodel: fix broken tests #309678

Merged
merged 1 commit into from
May 7, 2024
Merged

qmenumodel: fix broken tests #309678

merged 1 commit into from
May 7, 2024

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented May 7, 2024 •
edited
Loading

Description of changes

  • Fix failling tests due to missing gobject-introspection

ZHF: 309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient added the 0.kind: ZHF Fixes Fixes during the ZHF campaign label May 7, 2024
@Sigmanificient Sigmanificient changed the title qmenumodel: disable broken tests qmenumodel: fix broken tests May 7, 2024
@ofborg ofborg bot requested a review from OPNA2608 May 7, 2024 01:06
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels May 7, 2024
@Mic92 Mic92 merged commit e621740 into NixOS:master May 7, 2024
38 of 43 checks passed
@Sigmanificient Sigmanificient deleted the zhf-qmenumodel-fix branch May 7, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPNA2608 OPNA2608 Awaiting requested review from OPNA2608

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the ZHF campaign 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sigmanificient @Mic92