Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.scrapy: unbreak tests with upstream patch #309729

Merged
merged 1 commit into from May 7, 2024
Merged

python311Packages.scrapy: unbreak tests with upstream patch #309729

merged 1 commit into from May 7, 2024

Conversation

ghost
Copy link

@ghost ghost commented May 7, 2024

scrapy/scrapy@b1fe97d fixes test test_get_func_args

https://hydra.nixos.org/build/257501178
ZHF: #309482

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ghost
Copy link
Author

ghost commented May 7, 2024

(msg deleted -- wrong PR)

@fabaff
Copy link
Member

fabaff commented May 7, 2024

Result of nixpkgs-review pr 309729 run on x86_64-linux 1

2 packages failed to build:
  • python312Packages.scrapy-deltafetch
  • python312Packages.scrapy-deltafetch.dist
14 packages built:
  • python311Packages.scrapy
  • python311Packages.scrapy-deltafetch
  • python311Packages.scrapy-deltafetch.dist
  • python311Packages.scrapy-fake-useragent
  • python311Packages.scrapy-fake-useragent.dist
  • python311Packages.scrapy-splash
  • python311Packages.scrapy-splash.dist
  • python311Packages.scrapy.dist
  • python312Packages.scrapy
  • python312Packages.scrapy-fake-useragent
  • python312Packages.scrapy-fake-useragent.dist
  • python312Packages.scrapy-splash
  • python312Packages.scrapy-splash.dist
  • python312Packages.scrapy.dist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants