Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.{pathlib-abc,weasel}: {revert, relax deps} #309741

Merged
merged 2 commits into from May 7, 2024
Merged

python311Packages.{pathlib-abc,weasel}: {revert, relax deps} #309741

merged 2 commits into from May 7, 2024

Conversation

ghost
Copy link

@ghost ghost commented May 7, 2024

Description of changes

Revert "python3Packages.pathlib-abc: 0.1.1 -> 0.2.0" again for same reason as #299791 (fix pathy, the only consumer). update was part of #305152
https://hydra.nixos.org/build/258375435

relax typer dep to fix python311Packages.weasel
https://hydra.nixos.org/build/258353631

ZHF: #309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ghost
Copy link
Author

ghost commented May 7, 2024

failures due to python3.12-smart-open-7.0.4 failing: https://hydra.nixos.org/build/258346134

Result of nixpkgs-review run on x86_64-linux 1

4 packages failed to build:
  • python312Packages.pathy
  • python312Packages.pathy.dist
  • python312Packages.weasel
  • python312Packages.weasel.dist
20 packages built:
  • python311Packages.fastai
  • python311Packages.fastai.dist
  • python311Packages.pathlib-abc
  • python311Packages.pathlib-abc.dist
  • python311Packages.pathy
  • python311Packages.pathy.dist
  • python311Packages.spacy
  • python311Packages.spacy-lookups-data
  • python311Packages.spacy-lookups-data.dist
  • python311Packages.spacy-transformers
  • python311Packages.spacy-transformers.dist
  • python311Packages.spacy.dist
  • python311Packages.textacy
  • python311Packages.textacy.dist
  • python311Packages.textnets
  • python311Packages.textnets.dist
  • python311Packages.weasel
  • python311Packages.weasel.dist
  • python312Packages.pathlib-abc
  • python312Packages.pathlib-abc.dist

@ghost ghost changed the title python3Packages.{pathlib-abc,weasel}: {revert, relax deps} python311Packages.{pathlib-abc,weasel}: {revert, relax deps} May 7, 2024
@ofborg ofborg bot requested a review from GaetanLepage May 7, 2024 05:40
@GaetanLepage GaetanLepage requested a review from mweinelt May 7, 2024 07:38
@wegank wegank merged commit db58f2b into NixOS:master May 7, 2024
28 of 30 checks passed
@ghost ghost deleted the pathy-revert branch May 7, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants