Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awscli: relax deps botocore #309747

Merged
merged 1 commit into from May 7, 2024
Merged

awscli: relax deps botocore #309747

merged 1 commit into from May 7, 2024

Conversation

ghost
Copy link

@ghost ghost commented May 7, 2024

Description of changes

https://hydra.nixos.org/build/257375388

 Checking runtime dependencies for awscli-1.32.58-py3-none-any.whl
  - botocore==1.34.58 not satisfied by version 1.34.87

ZHF: #309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ghost
Copy link
Author

ghost commented May 7, 2024

Result of nixpkgs-review run on x86_64-linux 1

10 packages built:
  • awscli
  • awscli.dist
  • bash-my-aws
  • git-remote-codecommit
  • git-remote-codecommit.dist
  • iceshelf
  • nimbo
  • nimbo.dist
  • pacu
  • pacu.dist

@fabaff
Copy link
Member

fabaff commented May 7, 2024

Result of nixpkgs-review pr 309747 run on x86_64-linux 1

10 packages built:
  • awscli
  • awscli.dist
  • bash-my-aws
  • git-remote-codecommit
  • git-remote-codecommit.dist
  • iceshelf
  • nimbo
  • nimbo.dist
  • pacu
  • pacu.dist

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 8a70e15 into NixOS:master May 7, 2024
25 of 26 checks passed
@ghost ghost deleted the awscli branch May 7, 2024 11:01
jcaesar pushed a commit to jcaesar/sysflake that referenced this pull request May 8, 2024
@natsukium
Copy link
Member

As noted in the comment, the versions of awscli and botocore need to be synchronized.
see #310068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants