resp-app: fix broken build after snappy 1.2.0 upgrade #309874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snappy 1.2.0 changes the signature of the 'Compress' interface. The new interface is backwards compatible. However, we pull in Snappy source code via the Git submodules. The submodule provides the old header file for Snappy (pre 1.2.0) and is used during build time. While we provide a newer version of the library (1.2.0) with a different signature of 'Compress'. Since we are using our system library anyway, we just remove the problematic submodule in the patch phase. The commit in question in the Snappy repository is 766d24c95e345d4d06bfd3cc5787c2da3e025fab.
ofborg
bot
added
10.rebuild-darwin: 0
|
Result of 1 package built:
|
getchoo
approved these changes
May 8, 2024
getchoo
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snappy 1.2.0 changes the signature of the 'Compress' interface. The new interface is backwards compatible. However, we pull in Snappy source code via the Git submodules. The submodule provides the old header file for Snappy (pre 1.2.0) and is used during build time. While we provide a newer version of the library (1.2.0) with a different signature of 'Compress'. Since we are using our system library anyway, we just remove the problematic submodule in the patch phase.
The commit in question in the Snappy repository is 766d24c95e345d4d06bfd3cc5787c2da3e025fab.
Description of changes
ZHF: #309482
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.