Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.python-keycloak: 2.6.0 -> 4.0.0 #309942

Merged
merged 3 commits into from
May 7, 2024

Conversation

kiike
Copy link
Member

@kiike kiike commented May 7, 2024

Description of changes

This PR updates the package to version 4.0.0. The build is successful so perhaps it will help with the ZHF: #309482 campaign.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kiike kiike added the 0.kind: ZHF Fixes Fixes during the ZHF campaign label May 7, 2024
Copy link
Member

@leona-ya leona-ya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this, even though this is a breaking change as it the package was broken before and no package depends on this (and this is only a python module).

@fabaff
Copy link
Member

fabaff commented May 7, 2024

Result of nixpkgs-review pr 309942 run on x86_64-linux 1

4 packages built:
  • python311Packages.python-keycloak
  • python311Packages.python-keycloak.dist
  • python312Packages.python-keycloak
  • python312Packages.python-keycloak.dist

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 7d9adba into NixOS:master May 7, 2024
23 of 24 checks passed
@kiike
Copy link
Member Author

kiike commented May 8, 2024

Thanks for the feedback and the changes!

@kiike kiike deleted the zhf/python311/keycloak branch May 9, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants