-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signal-desktop-beta: only build on x86_64-linux #310053
Conversation
pkgs/applications/networking/instant-messengers/signal-desktop/default.nix
Outdated
Show resolved
Hide resolved
ee6a333
to
fa8e609
Compare
Relevant: #286188 Currently that PR is also modifying the |
fa8e609
to
f141b46
Compare
pkgs/applications/networking/instant-messengers/signal-desktop/default.nix
Outdated
Show resolved
Hide resolved
I think we should wait for #286188 to be merged before doing anything here as we're still forming a consensus on the |
f141b46
to
5faec52
Compare
@ofborg eval |
@teutat3s you should be using |
Upstream does not provide packages for aarch64-linux: > Note that these instructions only work for 64 bit Debian-based Linux > distributions Source: https://support.signal.org/hc/en-us/articles/360007318471-Signal-Beta Formatted using nixfmt-rfc-style
5faec52
to
ed125cf
Compare
@kirillrdy Done. |
In my opinion, this change does not interfere with the other mentioned PR and can be reviewed and merged independently. |
How so? Both PRs modify the same file. Since #286188 was created first and there is already a discussion about how to deal with the file this PR is trying to modify, I think it will be better to wait and see what consensus will be reached, so later this PR can be rebased and follow that consensus |
That PR seems to be stalled and needs to be rebased anyway... |
Description of changes
Build for
aarch64-linux
is currently failing since forever.Upstream does not provide packages for aarch64-linux:
Source: https://support.signal.org/hc/en-us/articles/360007318471-Signal-Beta
nixfmt-rfc-style
ZHF: #309482
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.