Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal-desktop-beta: only build on x86_64-linux #310053

Merged
merged 1 commit into from
May 13, 2024

Conversation

teutat3s
Copy link
Member

@teutat3s teutat3s commented May 8, 2024

Description of changes

Build for aarch64-linux is currently failing since forever.

Upstream does not provide packages for aarch64-linux:

Note that these instructions only work for 64 bit Debian-based Linux
distributions

Source: https://support.signal.org/hc/en-us/articles/360007318471-Signal-Beta

  • Formatted using nixfmt-rfc-style

ZHF: #309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@teutat3s teutat3s added the 0.kind: ZHF Fixes Fixes during the ZHF campaign label May 8, 2024
@teutat3s teutat3s force-pushed the signal-desktop-beta-fix-arch branch from ee6a333 to fa8e609 Compare May 8, 2024 11:38
@teutat3s teutat3s requested a review from kirillrdy May 8, 2024 11:38
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels May 8, 2024
@DontEatOreo
Copy link
Member

Relevant: #286188

Currently that PR is also modifying the pkgs/applications/networking/instant-messengers/signal-desktop/default.nix

@teutat3s teutat3s force-pushed the signal-desktop-beta-fix-arch branch from fa8e609 to f141b46 Compare May 8, 2024 14:58
@teutat3s teutat3s requested a review from DontEatOreo May 8, 2024 14:58
@DontEatOreo
Copy link
Member

I think we should wait for #286188 to be merged before doing anything here as we're still forming a consensus on the pkgs/applications/networking/instant-messengers/signal-desktop/default.nix

@teutat3s teutat3s force-pushed the signal-desktop-beta-fix-arch branch from f141b46 to 5faec52 Compare May 8, 2024 16:02
@teutat3s teutat3s requested a review from wegank May 8, 2024 16:02
@teutat3s
Copy link
Member Author

teutat3s commented May 8, 2024

@ofborg eval

@kirillrdy
Copy link
Member

@teutat3s you should be using nixfmt-rfc-style for formatting

Upstream does not provide packages for aarch64-linux:
> Note that these instructions only work for 64 bit Debian-based Linux
> distributions
Source: https://support.signal.org/hc/en-us/articles/360007318471-Signal-Beta

Formatted using nixfmt-rfc-style
@teutat3s teutat3s force-pushed the signal-desktop-beta-fix-arch branch from 5faec52 to ed125cf Compare May 8, 2024 23:33
@teutat3s
Copy link
Member Author

teutat3s commented May 8, 2024

@kirillrdy Done.

@teutat3s
Copy link
Member Author

teutat3s commented May 9, 2024

In my opinion, this change does not interfere with the other mentioned PR and can be reviewed and merged independently.

@DontEatOreo
Copy link
Member

How so? Both PRs modify the same file. Since #286188 was created first and there is already a discussion about how to deal with the file this PR is trying to modify, I think it will be better to wait and see what consensus will be reached, so later this PR can be rebased and follow that consensus

@wegank
Copy link
Member

wegank commented May 13, 2024

That PR seems to be stalled and needs to be rebased anyway...

@wegank wegank merged commit 9519688 into NixOS:master May 13, 2024
24 of 25 checks passed
@teutat3s teutat3s deleted the signal-desktop-beta-fix-arch branch May 15, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the ZHF campaign 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants