Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testers.hasPkgConfigModules: fix bug in versionCheck handling #311069

Merged
merged 4 commits into from
May 20, 2024
Merged

testers.hasPkgConfigModules: fix bug in versionCheck handling #311069

merged 4 commits into from
May 20, 2024

Commits on May 12, 2024

  1. tests.testers.hasPkgConfigModules: test the versionCheck parameter 

    Shell script is currently buggy and effectively ignores the value, always enforcing version match:
  NixOS#307770 (comment)
    @nbraud
    nbraud committed May 12, 2024
    Configuration menu
    Copy the full SHA
    1d4d9fa View commit details
    Browse the repository at this point in the history

  2. testers.hasPkgConfigModules: fix versionCheck conditional 

    Broke tests, as the version check was effectively always enabled:
  NixOS#307770 (comment)
    @nbraud
    nbraud committed May 12, 2024
    Configuration menu
    Copy the full SHA
    4af3b80 View commit details
    Browse the repository at this point in the history

  3. testers.hasPkgConfigModules: don't display ❌ on ignored version misma… 

    …tches
    @nbraud
    nbraud committed May 12, 2024
    Configuration menu
    Copy the full SHA
    43efaaa View commit details
    Browse the repository at this point in the history

  4. fixup! testers.hasPkgConfigModules: don't display ❌ on ignored versio… 

    …n mismatches
    @nbraud
    nbraud committed May 12, 2024
    Configuration menu
    Copy the full SHA
    bf4d46e View commit details
    Browse the repository at this point in the history