Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

povray: build with gcc12 #315287

Merged
merged 1 commit into from
May 30, 2024
Merged

povray: build with gcc12 #315287

merged 1 commit into from
May 30, 2024

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented May 28, 2024

Description of changes

Building with gcc13 makes it fail to parse some scenes: POV-Ray/povray#460
Fixes #311017

ZHF: #309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Building with gcc13 makes it fail to parse some scenes:
POV-Ray/povray#460
Fixes NixOS#311017
@fgaz
Copy link
Member Author

fgaz commented May 28, 2024

@GrahamcOfBorg build toppler

@fgaz fgaz added the backport release-24.05 Backport PR automatically label May 28, 2024
@fgaz fgaz added the 0.kind: ZHF Fixes Fixes during the ZHF campaign label May 30, 2024
@SuperSandro2000 SuperSandro2000 merged commit c2df152 into NixOS:master May 30, 2024
41 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.05:

@fgaz fgaz deleted the povray/gcc12 branch May 30, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: toppler
2 participants