Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.05] pe-parse: fix build on darwin #315984

Merged
merged 1 commit into from
May 30, 2024
Merged

[Backport release-24.05] pe-parse: fix build on darwin #315984

merged 1 commit into from
May 30, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 30, 2024 •
edited by risicle
Loading

Bot-based backport to release-24.05, triggered by a label in #315748.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@wegank @github-actions
pe-parse: fix build on darwin
3a49fc3 
(cherry picked from commit 4a90d51)
@github-actions github-actions bot mentioned this pull request May 30, 2024
Merged
13 tasks
@risicle risicle added the 0.kind: ZHF Fixes Fixes during the ZHF campaign label May 30, 2024
@risicle
Copy link
Contributor

risicle commented May 30, 2024

ZHF #309482

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 30, 2024
@ofborg ofborg bot requested a review from arcz May 30, 2024 21:23
risicle
risicle approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review happy, macos 12 x86_64

@risicle risicle merged commit b4a0f7e into release-24.05 May 30, 2024
23 of 24 checks passed
@risicle risicle deleted the backport-315748-to-release-24.05 branch May 30, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@arcz arcz Awaiting requested review from arcz

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the ZHF campaign 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@risicle @wegank