Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.{stringly,treelog}: drop checkPhase #316126

Merged
merged 2 commits into from
May 31, 2024

Conversation

wegank
Copy link
Member

@wegank wegank commented May 31, 2024

Description of changes

There are no tests...

ZHF: #309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank changed the title python312Packages.treelog: drop checkPhase python312Packages.{stringly,treelog}: drop checkPhase May 31, 2024
Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both builds on x86_64-linux.

Running phase: installCheckPhase

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

@Sigmanificient Sigmanificient added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 31, 2024
@ofborg ofborg bot requested review from Scriptkiddi May 31, 2024 11:48
@wegank wegank added the backport release-24.05 Backport PR automatically label May 31, 2024
@NickCao NickCao merged commit a96302d into NixOS:master May 31, 2024
34 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.05 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants