Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pwalarmctl: init at 0.1.0 #316279

Merged
merged 1 commit into from
Jun 12, 2024
Merged

pwalarmctl: init at 0.1.0 #316279

merged 1 commit into from
Jun 12, 2024

Conversation

amyipdev
Copy link
Contributor

Description of changes

This patch adds pwalarmctl, a controller and status tool for the pwalarmd daemon that was merged in #315703.

Homepage/repo: https://github.com/amyipdev/pwalarmd (pwalarmctl is a subproject in the same repo)

Note: because of the build structure of pwalarmctl/pwalarmd, the build instructions have to run cargo check to run the greater project build script, thus requiring the dependencies of pwalarmd (pkg-config and alsa-lib).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 31, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 2, 2024
@amyipdev
Copy link
Contributor Author

amyipdev commented Jun 2, 2024

Since this has approval, can it be merged? @heisfer @wegank

This patch adds pwalarmctl, a controller and status tool for the
pwalarmd daemon that was merged in NixOS#315703.

Signed-off-by: Amy Parker <[email protected]>
@wegank wegank merged commit 6cf4596 into NixOS:master Jun 12, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants