-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib.systems.riscv-multiplatform: linux-kernel config improvements #316724
Conversation
Like aarch64, riscv platforms require many drivers to be builtin to boot.
SERIAL_OF_PLATFORM has been y in riscv defconfig since 2018 Reference: torvalds/linux@33c57c0
What does
|
Even if a kconfig option defaults to
It's part of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, works for me on VisionFive2 board without manually force PINCTRL_STARFIVE_JH7110_SYS = yes;
. Kernel is booting fine 👍
@onny Do you know who else is working on riscv? I'd like to ping more people before merging such a potentially breaking change. |
Unfortunately not. We should create a platform maintainer group :) |
There is @NixOS/exotic-platform-maintainers |
There is also #riscv:nixos.org which is scoped to RISC-V topic. |
Are we save merging this or do we need some more tests? |
Let's merge this, it should be a net profit for the riscv platform. Except for these really memory constrained devices that can benefit from a smaller kernel, but they should be using a trimmed down kernel config anyway. |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.