Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes extra backtick from manual #318061

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

PedroRegisPOAR
Copy link
Contributor

@PedroRegisPOAR PedroRegisPOAR commented Jun 7, 2024

Description of changes

Things done

Removed an extra backtick from manual.

Was reading this section: https://nixos.org/manual/nixos/stable/index.html#sec-nixos-test-shell-access

Note the ` in the end of last line in the image:
extra-backtick

Tested it with my local nixpkgs after removing it:

nix-build nixos/release.nix -A manual.x86_64-linux

Resulting path:

/nix/store/fa5vs0mbkd5xdjdn5qxj45vy9nrzf3ad-nixos-manual-html

Tested using flakes and remote branch:

EXPR_NIX='
  let
    nixpkgs = (builtins.getFlake "github:PedroRegisPOAR/nixpkgs/015e29a742b6b59946f947d65300e8c524e1f88b"); 
    pkgs = import nixpkgs {};

    manual = (import "${pkgs.path}/nixos/release.nix" {}).manual;
  in
    manual.x86_64-linux
'

nix \
build \
--impure \
--print-out-paths \
--expr \
"$EXPR_NIX"

Resulting path:

/nix/store/fa5vs0mbkd5xdjdn5qxj45vy9nrzf3ad-nixos-manual-html

Edits: had to force push to change commit message.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation labels Jun 7, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 7, 2024
@Ma27 Ma27 merged commit afa84d8 into NixOS:master Jun 9, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants