Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitbutler: init at 0.12.2 #318101

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Jun 7, 2024

Description of changes

https://gitbutler.com/

Closes #288567

This is meant to be an alternative to #289664, with some improvements being:

  • Adopting the new pnpm tooling from pnpm.fetchDeps: init #290715
  • Tauri's native bundles are used to reduce maintainer overhead
  • The project is contained in a single derivation, simplifying things
  • Updating to the latest release
  • Applying multiple suggestions from the previous PR

cc @hacker1024 as the author of the previous PR, @SuperSandro2000 as the one who suggested the move to the new pnpm tooling

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@getchoo getchoo requested a review from alyssais as a code owner June 7, 2024 21:23
@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Jun 7, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Jun 7, 2024
@matteo-pacini
Copy link
Contributor

Result of nixpkgs-review pr 318101 run on aarch64-darwin 1

1 package built:
  • gitbutler

Works fine on aarch64-darwin.

Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working on aarch64-darwin :)

@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 8, 2024
@0x61nas 0x61nas removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 9, 2024
@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 9, 2024
@hacker1024 hacker1024 mentioned this pull request Jun 9, 2024
13 tasks
Copy link
Member

@hacker1024 hacker1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still need to replace the libayatana-appindicator library as was done here?

@getchoo
Copy link
Member Author

getchoo commented Jun 9, 2024

Does this still need to replace the libayatana-appindicator library as was done here?

doesn't seem like it, no. fairly certain this is something to do with newer versions of tauri - i noticed it in modrinth-app as well

@0x61nas 0x61nas added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jun 9, 2024
@getchoo getchoo removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 10, 2024
@Aleksanaa Aleksanaa merged commit d95005a into NixOS:master Jun 22, 2024
35 checks passed
@getchoo getchoo deleted the pkgs/gitbutler/init branch June 22, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: lib The Nixpkgs function library 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: GitButler
6 participants