box86: init at 0.3.6 #318623
Merged
box86: init at 0.3.6 #318623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
|
@ofborg build box86 box86.passthru.tests |
|
cool, @OPNA2608, hit me up if I could help with anything else |
Yeshey
added a commit
to Yeshey/nixOS-Config
that referenced
this pull request
Jun 10, 2024
nixpkgs box86 merge request: NixOS/nixpkgs#318623, box86 issue I made: NixOS/nixpkgs#318623
|
any chance for this to go through? |
AndersonTorres
approved these changes
Jul 23, 2024
OPNA2608
added
the
12.approvals: 1
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #174113 (stale)
CC @Yeshey since you seem interested in box86
Heavily based on our box64 expression.
Second commit is maybe abit sketchy, so it's separate in case we don't want it.
Since box86 is only supported on 32-bit userland, its supported platforms can also only be 32-bit. But one may want to use it to run 32-bit x86 software on 64-bit non-x86 hardware as well. It's trivial to tell nix to cross-compile the package, but then the user would need to compile this on their own hardware since (AFAIU) the cache doesn't serve many 32-bit packages (especially on ARM I imagine?). This should work around this by mapping x86_64 -> i686 & aarch64 -> armv7l, which should hopefully let the cache be able to substitute this for ppl.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.