nodePackages.bash-language-server: remove attribute #319882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doronbehar i just saw the old bash-language-server had shellcheck in its path, we probably should keep it that way |
|
I can confirm that this now builds for me with: $ nix-shell -p nodePackages.bash-language-server -I nixpkgs='https://github.com/NyCodeGHG/nixpkgs/archive/1933c5e9e475eef4cab3e05e2368043a29980a9c.zip'Thank you for the quick fix :) |
|
Result of 1 package built:
|
|
Result of 1 package built:
|
1 task
bash-language-server has been packaged outside of nodePackages in NixOS#317954, but not correctly removed from nodePackages.
wegank
added
the
12.approvals: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/error-alias-bash-language-server-is-still-in-node-packages-nix/47027/2 |
SuperSandro2000
approved these changes
Jun 14, 2024
|
Sorry for the breakage and thanks for the quick fix 🙏 . I thought that only |
robbins
added a commit
to robbins/dots
that referenced
this pull request
Jun 15, 2024
robbins
added a commit
to robbins/dots
that referenced
this pull request
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
bash-language-server has been packaged outside of nodePackages in #317954, but not correctly removed from nodePackages.
Closes #319871
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.