Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.vim-language-server: drop, replace with vim-language-server #322505

Merged

Conversation

tomodachi94
Copy link
Member

Description of changes

Replaced by the mainspace "vim-language-server", which was added in #296847.

Added an alias to the above in the nodePackages attrset.

I don't consider this to be a breaking change, since this PR aliases the package to another equivalent one.

Tracking: #229475

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Replaced by the mainspace "vim-language-server", which was added in.
NixOS#296847.

Added an alias to the above.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 25, 2024
@tomodachi94 tomodachi94 changed the title nodePackages.vim-language-server: drop nodePackages.vim-language-server: drop, replace with vim-language-server Jun 25, 2024
@JohnRTitor JohnRTitor merged commit ed0de36 into NixOS:master Jun 26, 2024
23 checks passed
@tomodachi94 tomodachi94 deleted the drop/nodePackages.vim-language-server branch June 26, 2024 05:32
@tomodachi94 tomodachi94 added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nodejs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
Status: Dropped
Development

Successfully merging this pull request may close these issues.

3 participants