Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.ipython-genutils: remove nose test dependency #323410

Closed
wants to merge 1 commit into from

Conversation

collares
Copy link
Member

@collares collares commented Jun 29, 2024

Description of changes

This package was disabled because upstream said "DO NOT USE" on PyPI, and because it depends on the unmaintained nose test framework. There's some nuance to the first point, however. As you can see by looking at the repository README, the full recommendation is that "no packages outside IPython/Jupyter should depend on it". Unfortunately, nbclassic is an actively maintained part of Jupyter which depends on ipython-genutils, so we have to keep it alive for now.

The options to do so are either to keep nose alive (as Arch does) or to migrate nose tests to pytest (as openSUSE does). I picked the latter option and imported the openSUSE patch. Three and a half years ago, openSUSE devs notified upstream at ipython/ipython_genutils#17, but upstream thought fully eliminating ipython-genutils was in the near future; it hasn't happened so far.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@collares
Copy link
Member Author

collares commented Jun 29, 2024

I only really care about Sage and Sage 10.3 already removed nbclassic support in sagemath/sage#36129, so I'm fine with closing this PR (I'm removing the dependency in #323426). However, note that jupyterhub includes nbclassic in its nativeCheckInputs, so there might still be some value in importing the openSUSE patch. Note also that nbclassic is only used for a single test there.

@vcunat vcunat changed the base branch from staging-next to master July 6, 2024 07:05
@vcunat vcunat changed the title [staging-next] python312Packages.ipython-genutils: remove nose test dependency python312Packages.ipython-genutils: remove nose test dependency Jul 6, 2024
@SuperSandro2000
Copy link
Member

Can you please rebase?

@mweinelt
Copy link
Member

mweinelt commented Jul 9, 2024

Included in #325669

@mweinelt mweinelt closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants