Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wyoming-piper: fix changelog and homepage #323656

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

GrumpyMeow
Copy link
Contributor

Fixed wrong meta information of piper.nix package.

Description of changes

Small fixes of meta information of Wyoming Piper package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GrumpyMeow
Copy link
Contributor Author

My first Pull Request for Nix.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 30, 2024
@Shawn8901
Copy link
Contributor

Shawn8901 commented Jun 30, 2024

Please check https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions . The commit message does not follow the naming conventions.

The change itself looks reasonable to me.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 30, 2024
@eclairevoyant eclairevoyant changed the title Updated wrong meta of piper.nix wyoming-piper: fix changelog and homepage Jul 1, 2024
@eclairevoyant eclairevoyant merged commit 3881b74 into NixOS:master Jul 1, 2024
25 of 27 checks passed
@GrumpyMeow GrumpyMeow deleted the fix-meta-wyoming-piper branch July 3, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants