release-cuda: build with config.cudaSupport #324379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomeoneSerge
commented
Jul 3, 2024
ofborg
bot
added
10.rebuild-darwin: 0
SomeoneSerge
force-pushed
the
feat/release-cuda
branch
from
171472d
to
8da4dd7
Compare
SomeoneSerge
changed the title
SomeoneSerge
force-pushed
the
feat/release-cuda
branch
2 times, most recently
from
31ef669
to
6e192ad
Compare
SomeoneSerge
commented
Jul 4, 2024
There was a problem hiding this comment.
❯ time nix shell nixpkgs#hydra_unstable --command hydra-eval-jobs pkgs/top-level/release-cuda.nix -I . 2>/dev/null | jq length
1847
real 0m8.774s
user 0m0.156s
sys 0m0.420s
d889d3d
to
38315ca
Compare
SomeoneSerge
force-pushed
the
feat/release-cuda
branch
2 times, most recently
from
35f701a
to
015d2ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The NixOS Hydra still doesn't build CUDA and unfree packages (except for when we misspecify the licenses, like for PyPi wheels which may or may not include hidden CUDA and MKL bits), but https://hydra.nix-community.org/jobset/nixpkgs/cuda-nixos-unstable might: thanks to nix-community/infra#1335.
CC @zimbatm @NixOS/cuda-maintainers
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.