Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxtx-clipper: init at unstable-2024-02-17 #324571

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Vcele
Copy link

@Vcele Vcele commented Jul 4, 2024

Description of changes

Adding proxtx-clipper: clip-bot that allows you to clip the last 30 seconds of audio in a voicechat.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 4, 2024
@Vcele
Copy link
Author

Vcele commented Jul 6, 2024

Result of nixpkgs-review pr 324571 run on x86_64-linux 1

@Vcele Vcele added 8.has: package (new) This PR adds a new package 6.topic: rust labels Aug 2, 2024
@Vcele Vcele reopened this Aug 3, 2024
Copy link
Contributor

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to squash your commits

@Vcele
Copy link
Author

Vcele commented Aug 30, 2024

You need to squash your commits

Why isn't it possible to use the squash when merge option?

@Pandapip1
Copy link
Contributor

Why isn't it possible to use the squash when merge option?

It's not enabled on this repo, and it's really not hard to just interactively rebase.

@Vcele
Copy link
Author

Vcele commented Aug 30, 2024

Why isn't it possible to use the squash when merge option?

It's not enabled on this repo, and it's really not hard to just interactively rebase.

Ok I just was curious. I will squash it once I'm on my PC again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux awaiting_changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants