gemmi: init at 0.6.6 #324704
Merged
gemmi: init at 0.6.6 #324704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 2 packages built successfully:
|
ofborg
bot
added
8.has: package (new)
getchoo
suggested changes
Jul 5, 2024
pkgs/by-name/ge/gemmi/package.nix
Outdated
| meta = { | ||
| description = "Macromolecular crystallography library and utilities"; | ||
| homepage = "https://github.com/project-gemmi/gemmi"; | ||
| changelog = "https://github.com/project-gemmi/gemmi/releases/tag/${finalAttrs.src.rev}"; |
There was a problem hiding this comment.
Suggested change
| changelog = "https://github.com/project-gemmi/gemmi/releases/tag/${finalAttrs.src.rev}"; | |
| changelog = "https://github.com/project-gemmi/gemmi/releases/tag/v${finalAttrs.version}"; |
this currently evaluates to "https://github.com/project-gemmi/gemmi/releases/tag/refs/tags/v0.6.6", which is not a link to the actual changelog
getchoo
approved these changes
Jul 5, 2024
getchoo
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
macromolecular crystallography library and utilities
https://github.com/project-gemmi/gemmi
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.