Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.prettier-plugin-go-template: add package #324782

Closed
wants to merge 2 commits into from
Closed

nodePackages.prettier-plugin-go-template: add package #324782

wants to merge 2 commits into from

Conversation

jukremer
Copy link
Contributor

@jukremer jukremer commented Jul 5, 2024

Description of changes

Added nodePackages.prettier-plugin-go-template. #324008

Things done

I followed the steps here.

  • Added the package to node-packages.json.

  • Ran ./pkgs/development/node-packages/generate.sh.

  • Tested nix-build -A nodePackages.prettier-plugin-go-template.

    • npm WARN config production Use --omit=dev instead. Not sure if this is relevant.
  • I also included the full result of ./pkgs/development/node-packages/generate.sh in a second commit.

  • I'm not sure if prettier should be added as a dependency.

  • Built on platform(s)

    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:

  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

  • Tested basic functionality of all binary files (usually in ./result/bin/)

  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.


Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jul 5, 2024
@ofborg ofborg bot requested a review from Luflosi July 5, 2024 11:12
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 6, 2024
@jukremer
Copy link
Contributor Author

jukremer commented Jul 7, 2024

@Luflosi @wegank I probably need to remove the second commit, right?

@wegank
Copy link
Member

wegank commented Jul 7, 2024

We're actually migrating packages out of nodePackages (see #229475), so adding a package there is not optimal...

@jukremer jukremer closed this Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nodejs 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants