Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fichub-cli: init at 0.10.3 #325173

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fichub-cli: init at 0.10.3 #325173

merged 1 commit into from
Jul 24, 2024

Conversation

Samasaur1
Copy link
Member

Description of changes

https://github.com/FicHub/fichub-cli

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/fi/fichub-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fi/fichub-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fi/fichub-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fi/fichub-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fi/fichub-cli/package.nix Show resolved Hide resolved
pkgs/by-name/fi/fichub-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fi/fichub-cli/package.nix Outdated Show resolved Hide resolved
@Samasaur1
Copy link
Member Author

I'm so tempted by the little "Commit suggestion" button but i know i'd have to squash it anyway :(

@Samasaur1 Samasaur1 changed the title fichub-cli: init at 0.9.4 fichub-cli: init at 0.10.2 Jul 17, 2024
Comment on lines 45 to 52
# These all attempt to access the network
disabledTests = [
"test_cli_url"
"test_cli_list_url"
"test_cli_infile"
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# These all attempt to access the network
disabledTests = [
"test_cli_url"
"test_cli_list_url"
"test_cli_infile"
];
disabledTestPaths = [
# Loading tests tries to download something from pypi.org
"tests/test_cli.py"
];

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I disabled those tests individually and not the entire file is that there is one test in that file that doesn't try to access the network and thus succeeds (even though all it is doing is checking the version). Did you mean to disable that as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, I just got an error for this test as well. Not sure why it was working initially

@Samasaur1
Copy link
Member Author

@SuperSandro2000 disabling all tests with disabledTestPaths makes the package fail to build on both linux and darwin:

============================= test session starts ==============================
platform linux -- Python 3.12.4, pytest-8.2.2, pluggy-1.5.0
rootdir: /build/fichub_cli-0.10.2
configfile: pyproject.toml
collecting ... ^Mcollected 0 items

============================ no tests ran in 0.02s =============================
/nix/store/5r0df66ikad3xw06azlqvswcvncll8wa-stdenv-linux/setup: line 1641: pop_var_context: head of shell_variables not a function context

@Samasaur1
Copy link
Member Author

Samasaur1 commented Jul 20, 2024

pytest exits with a code of 5 if no tests are selected (pytest-dev/pytest#2393)

@Samasaur1 Samasaur1 changed the title fichub-cli: init at 0.10.2 fichub-cli: init at 0.10.3 Jul 20, 2024
@Aleksanaa Aleksanaa merged commit ff0610c into NixOS:master Jul 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants