-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fichub-cli: init at 0.10.3 #325173
fichub-cli: init at 0.10.3 #325173
Conversation
I'm so tempted by the little "Commit suggestion" button but i know i'd have to squash it anyway :( |
# These all attempt to access the network | ||
disabledTests = [ | ||
"test_cli_url" | ||
"test_cli_list_url" | ||
"test_cli_infile" | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# These all attempt to access the network | |
disabledTests = [ | |
"test_cli_url" | |
"test_cli_list_url" | |
"test_cli_infile" | |
]; | |
disabledTestPaths = [ | |
# Loading tests tries to download something from pypi.org | |
"tests/test_cli.py" | |
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I disabled those tests individually and not the entire file is that there is one test in that file that doesn't try to access the network and thus succeeds (even though all it is doing is checking the version). Did you mean to disable that as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, I just got an error for this test as well. Not sure why it was working initially
@SuperSandro2000 disabling all tests with
|
pytest exits with a code of |
Description of changes
https://github.com/FicHub/fichub-cli
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.