Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.asar: init at 0.14.0 #32615

Merged
merged 1 commit into from
Dec 17, 2017
Merged

nodePackages.asar: init at 0.14.0 #32615

merged 1 commit into from
Dec 17, 2017

Conversation

xvapx
Copy link
Contributor

@xvapx xvapx commented Dec 12, 2017

Motivation for this change

To add the asar command line utility, to be able to pack/unpack asar archives, which are used in some electron apps.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This PR is the result of adding asar to pkgs/development/node-packages/node-packages-v6.json and then running pkgs/development/node-packages/generate.sh

@xvapx
Copy link
Contributor Author

xvapx commented Dec 12, 2017

I think asar might be useful to edit some defaults in electron apps, which I would like to do in the work I'm doing on #32401, to modify a hardcoded directory.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 12, 2017
@Mic92 Mic92 merged commit 28541e2 into NixOS:master Dec 17, 2017
@xvapx xvapx deleted the asar branch February 21, 2018 08:28
@dotlambda dotlambda mentioned this pull request Aug 27, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants