Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniupnpc: 2.2.7 -> 2.2.8, again #326402

Merged
merged 39 commits into from
Jul 12, 2024
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
4b9186a
Reapply "miniupnpc: 2.2.7 -> 2.2.8 , support static build"
emilazy Jul 11, 2024
b0ee42d
transmission_4: fix build error with our miniupnp
doronbehar Jul 11, 2024
579e16b
transmission_3: add patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
314f169
bitcoin: add upstream patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
37087ef
bitcoin-abc: add upstream patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
2257420
i2pd: add upstream patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
2bf72c4
sunshine: add upstream patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
72446c1
flycast: add upstream patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
58b9ac8
bitcoind-knots: add upstream patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
416aae7
retroshare: 0.6.6 -> 0.6.7.2
emilazy Jul 11, 2024
edc7668
retroshare: add upstream patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
0abdd64
namecoind: add upstream patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
c9ba793
groestlcoind: add upstream patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
2e46cc8
eiskaltdcpp: add upstream patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
77fbc57
litecoin: add patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
0539f86
monero-cli: build with Ninja
emilazy Jul 11, 2024
497259f
monero-cli: add patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
f96b9b9
haven-cli: build with Ninja
emilazy Jul 11, 2024
5a149da
haven-cli: use patches from monero-cli
emilazy Jul 11, 2024
de9db75
alephone: add patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
b9f0aa8
zeroad: add patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
7e44344
yaup: add patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
c5ff204
dante: add patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
ca39d29
chiaki4deck: add patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
9511ce9
elements: add patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
fcf6c25
particl-core: add patch for miniupnpc 2.2.8
emilazy Jul 11, 2024
defe4ae
gridcoin-research: 5.4.8.0 -> 5.4.8.0-hotfix-1
emilazy Jul 11, 2024
38d971a
pshs: move to `pkgs/by-name`
emilazy Jul 11, 2024
f5b70e5
pshs: format with `nixfmt-rfc-style`
emilazy Jul 11, 2024
5bc8c69
pshs: modernize
emilazy Jul 11, 2024
4d9b599
pshs: support all Unix platforms
emilazy Jul 11, 2024
f67cebe
pshs: 0.3.4 -> 0.4.3
emilazy Jul 11, 2024
953b05c
qodem: move to `pkgs/by-name`
emilazy Jul 11, 2024
956487c
qodem: format with `nixfmt-rfc-style`
emilazy Jul 11, 2024
b78f96a
qodem: modernize
emilazy Jul 11, 2024
8dd4be4
qodem: fix build on Darwin
emilazy Jul 11, 2024
187349b
qodem: 1.0.1 -> 1.0.1-unstable-2022-02-12
emilazy Jul 11, 2024
6875020
qodem: add patches
emilazy Jul 11, 2024
4a46bb9
masari: drop
emilazy Jul 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions pkgs/by-name/ps/pshs/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -8,38 +8,47 @@
file,
qrencode,
miniupnpc,
nix-update-script,
}:

stdenv.mkDerivation rec {
stdenv.mkDerivation (finalAttrs: {
pname = "pshs";
version = "0.3.4";

src = fetchFromGitHub {
owner = "mgorny";
repo = "pshs";
rev = "v${version}";
rev = "v${finalAttrs.version}";
sha256 = "1j8j4r0vsmp6226q6jdgf9bzhx3qk7vdliwaw7f8kcsrkndkg6p4";
};

nativeBuildInputs = [
autoreconfHook
pkg-config
];

buildInputs = [
libevent
file
qrencode
miniupnpc
];

strictDeps = true;

# SSL requires libevent at 2.1 with ssl support
configureFlags = [ "--disable-ssl" ];

__structuredAttrs = true;

passthru.updateScript = nix-update-script { };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed? Updating this package should be trivial for both nix{,pkgs}-update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, it’s never been clear to me exactly where nixpkgs-update will update from. I know the main source is Repology, but that it can maybe also do GitHub releases? In this case though the newer releases are just tags and there are no corresponding GitHub releases. This at least lets maintainers/script/update.nix work where it doesn’t otherwise.

I asked about best practices on Matrix recently but there wasn’t really any answer. There has been some talk about either making nix-update-script the default, or doing a mass addition of it; see #325074.


meta = {
description = "Pretty small HTTP server - a command-line tool to share files";
mainProgram = "pshs";
homepage = "https://github.com/mgorny/pshs";
sourceProvenance = [ lib.sourceTypes.fromSource ];
license = lib.licenses.bsd3;
platforms = lib.platforms.linux;
};
}
})