Update vdirsyncer #33052
Update vdirsyncer #33052
Conversation
| @@ -0,0 +1,22 @@ | |||
| { lib, python3Packages, buildPythonPackage, fetchurl }: | |||
There was a problem hiding this comment.
no pythonPackages, individual packages as parameters
| version = "0.1.1"; | ||
| name = "${pname}-${version}"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
Does not work. I tested it, but it can't find the package. That's why I used fetchurl.
There was a problem hiding this comment.
because you request a zip. It needs `extension = "zip";'
| buildPythonPackage rec { | ||
| pname = "milksnake"; | ||
| version = "0.1.1"; | ||
| name = "${pname}-${version}"; |
| sha256 = "12bdyc2kjqpiq8wrbsk7ymcq2xdakri3bsvaqgsyzj33wyzbcwzy"; | ||
| }; | ||
|
|
||
| buildInputs = with python3Packages; [ |
|
|
||
| src = fetchurl { | ||
| url = "https://pypi.python.org/packages/04/12/358c2c7a27f06a71d69e44a4b7f62411524c25e6c7284b5a0f757a9ba068/milksnake-0.1.1.zip"; | ||
| sha256 = "12bdyc2kjqpiq8wrbsk7ymcq2xdakri3bsvaqgsyzj33wyzbcwzy"; | ||
| }; | ||
|
|
||
| buildInputs = with python3Packages; [ | ||
| propagatedBuildInputs = [ |
There was a problem hiding this comment.
Still, how is this going to work? If it uses cffi it tries to load a library, and for that it first needs to find it. How will it find that library outside build-time? And which library does it need?
| milksnake | ||
|
|
||
| pkgs.cargo | ||
| pkgs.rustc |
There was a problem hiding this comment.
Please import cargo and rustc without relying on pkgs. This is needed for vdirsyncer.override {} to work.
| pname = "milksnake"; | ||
| version = "0.1.1"; | ||
|
|
||
| src = fetchurl { |
| }; | ||
|
|
||
| propagatedBuildInputs = [ | ||
| cffi |
There was a problem hiding this comment.
I don't know how to do this, TBH.
| meta = with lib; { | ||
| description = "A python library that extends setuptools for binary extensions."; | ||
| homepage = https://pypi.python.org/pypi/milksnake/; | ||
| license = licenses.apl; |
| @@ -1,17 +1,17 @@ | |||
| { stdenv, fetchurl, python3Packages, glibcLocales }: | |||
| { stdenv, fetchurl, python3Packages, glibcLocales, pkgs, rust, cargo }: | |||
|
|
||
| # Packaging documentation at: | ||
| # https://github.com/untitaker/vdirsyncer/blob/master/docs/packaging.rst | ||
| let | ||
| pythonPackages = python3Packages; | ||
| in | ||
| pythonPackages.buildPythonApplication rec { | ||
| version = "0.16.3"; | ||
| version = "0.17.0a1"; | ||
| name = "vdirsyncer-${version}"; | ||
|
|
||
| src = fetchurl { |
|
|
||
| # Packaging documentation at: | ||
| # https://github.com/untitaker/vdirsyncer/blob/master/docs/packaging.rst | ||
| let | ||
| pythonPackages = python3Packages; | ||
| in | ||
| pythonPackages.buildPythonApplication rec { | ||
| version = "0.16.3"; | ||
| version = "0.17.0a1"; |
There was a problem hiding this comment.
we typically do not have alpha's in Nixpkgs.
There was a problem hiding this comment.
Feel free to leave this unmerged (even after the remaining issues with this PR are solved) until I can bump to a new stable release (if there is any).
|
closing as outdated, master has vdirsyncer 0.17.0a3 now. |
Motivation for this change
Targets #33050
Things done
vdirsyncerrequires a new dependency which is written in Rust. Unfortunately, these patches make me buildrustcfrom source (so I aborted this) so I cannot test whether packaging works.I'm not sure how to proceed here.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)