-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] devShellTools.buildShellEnv #330822
Draft
roberth
wants to merge
5
commits into
master
Choose a base branch
from
devShellTools-shell
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
roberth
added
the
significant
Novel ideas, large API changes, notable refactorings, issues with RFC potential, etc.
label
Jul 29, 2024
13 tasks
13 tasks
wegank
added
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Sep 10, 2024
roberth
commented
Oct 21, 2024
Comment on lines
+89
to
+93
export NIXPKGS_SHELL_TMP="$(mktemp -d --tmpdir nixpkgs-shell-${name}.XXXXXX)" | ||
export TMPDIR="$NIXPKGS_SHELL_TMP" | ||
export TEMPDIR="$NIXPKGS_SHELL_TMP" | ||
export TMP="$NIXPKGS_SHELL_TMP" | ||
export TEMP="$NIXPKGS_SHELL_TMP" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No NIX_BUILD_TOP
. Should we have it? It's not a build...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.status: merge conflict
This PR has merge conflicts with the target branch
6.topic: haskell
6.topic: stdenv
Standard environment
significant
Novel ideas, large API changes, notable refactorings, issues with RFC potential, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Note: this is currently draft, because it does not have sufficient tests and documentation for a number of features.
Help wanted :) This is a
NixOS/nixpkgs
branch, where all maintainers can push, but maybe sync with me first.Implement build shells and development shells in Nixpkgs for greater flexibility and evolution of the Nix shell concept.
nix develop
"shell" logic nix#7501nix run -f shell.nix --arg nixpkgs ./. devShell
(ie like running the output ofnix-build shell.nix -A devShell
)devShell
interface yourself.passthru.devShell = something custom;
devShellTools
: add environment functions #324789Terminology cheat sheet
nix shell
:nix env shell
make-derivation.nix
), useful for troubleshooting a buildmkShell
, or with other projects likecachix/devenv
,numtide/devshell
, etc, provided they'll implement thedevShell
interfaceTODO
devShell
attribute and the interface of its outputdevShell
nix develop
andnix print-dev-env
behaviors. This is very small and ok to duplicate.)devShell
attr for now)mkShell
return an impure shell by default, because it's for dev shells?nix develop
"shell" logic nix#7501Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.