Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concurrently: move out of nodePackages #332449

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

dotlambda
Copy link
Member

Description of changes

related to #229475

cc @jpetrucciani who originally packaged this in #143447

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@dotlambda dotlambda changed the title concurrently: move out of nodePackage concurrently: move out of nodePackages Aug 5, 2024
@ofborg ofborg bot requested a review from jpetrucciani August 5, 2024 10:39
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 5, 2024
@jpetrucciani
Copy link
Member

oh, TIL pnpm_8.fetchDeps! that's super handy

Copy link
Member

@jpetrucciani jpetrucciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested it with

nix run github:dotlambda/nixpkgs?ref=concurrently#concurrently -- --help

@dotlambda dotlambda merged commit 7b6306c into NixOS:master Aug 5, 2024
25 of 27 checks passed
@dotlambda dotlambda deleted the concurrently branch August 5, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants