-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-gyp: init at 10.2.0 #334377
node-gyp: init at 10.2.0 #334377
Conversation
@ofborg eval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this :). Changes look good to me, but I'd wait for more reviewers to respond... A nixpkgs-review report would be nice too.
Result of 2 packages failed to build:
6 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code-server
fails on master too, no new failures 🚀
Tested the update script, changes LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. The nodehun
package works, so I'm happy as far as the packages I maintain.
I wish this didn't require adding 5,000 lines of package-lock.json
though. One of the main motivations mentioned in #229475 is to avoid having a centralized update script that takes 4 hours to run. But breaking that up into separate packages that have their own update scripts and a large increase in lockfile data doesn't necessarily seem like an improvement. I see the node-gyp
repo doesn't provide a lockfile but it would be nice if there were some other way to do this. Approving though because I have no idea what that way would be :)
I too feel the same. I was wondering, do we have a clue why upstream won't track such a file in their repository? That's the best I found: |
Technically projects that use node-gyp should include it in their |
Description of changes
see #229475
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.