Octoprint: hardening and RFC 42 #335827
Draft
Octoprint: hardening and RFC 42 #335827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
PatrickDaG
force-pushed
the
octoprint-update
branch
from
c56804b
to
9d27b4d
Compare
PatrickDaG
changed the title
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
gador
approved these changes
Aug 20, 2024
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 2 packages blacklisted:
2 packages built:
|
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package blacklisted:
2 packages built:
|
PatrickDaG
force-pushed
the
octoprint-update
branch
from
9d27b4d
to
cef644d
Compare
|
I've added a release note. |
|
I'm ok with this 👍 @abbradar @gebner @WhittlesJr what do you think? |
wegank
added
the
2.status: merge conflict
PatrickDaG
force-pushed
the
octoprint-update
branch
from
cef644d
to
6b95da6
Compare
ofborg
bot
removed
the
2.status: merge conflict
Scrumplex
approved these changes
Oct 26, 2024
| }; | ||
| enableRaspberryPi = mkEnableOption "RaspberryPi specific hardware access rules"; |
There was a problem hiding this comment.
Suggested change
| enableRaspberryPi = mkEnableOption "RaspberryPi specific hardware access rules"; | |
| enableRaspberryPi = mkEnableOption "RaspberryPi specific hardware access rules" // { | |
| default = lib.versionOlder config.system.stateVersion "25.05"; | |
| }; |
PatrickDaG
force-pushed
the
octoprint-update
branch
2 times, most recently
from
2195eb2
to
fcdd2ee
Compare
wegank
added
the
2.status: merge conflict
ffmpeg is only used for timelapses which will just be disabled if the options isn't set. Additionally this allows people to ship their own ffmpeg.
PatrickDaG
force-pushed
the
octoprint-update
branch
from
fcdd2ee
to
5d00a73
Compare
PatrickDaG
force-pushed
the
octoprint-update
branch
from
5d00a73
to
2599d2e
Compare
ofborg
bot
added
11.by: package-maintainer
PatrickDaG
added
the
2.status: wait for branch‐off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I've added rfc 42 compliant options to the octoprint module, which in my opinion make it easier to read and understand.
Additionally I've added some basic systemd hardening for the service and remove the default enabled raspberryPi specific option. This might break some setup but previously for none raspberry Pi setups there was no option to remove the tempfiles.
Lastly I removed the ffmpeg patch from the package. This breaks timelapses for people using the package without the module, who I expecte to be able to, or even want to set their own ffmpeg, something that wasn't possible previously.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.