Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matterbridge: 1.26.0 -> 1.26.0-unstable-2024-08-27 #338232

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

katexochen
Copy link
Contributor

Description of changes

Found this due to the high number of vulnerabilities when scanning nixpkgs:

https://pkg.go.dev/vuln/GO-2024-3032
https://pkg.go.dev/vuln/GO-2024-3031
https://pkg.go.dev/vuln/GO-2024-3030
https://pkg.go.dev/vuln/GO-2024-3028
https://pkg.go.dev/vuln/GO-2024-3025
https://pkg.go.dev/vuln/GO-2024-3024
https://pkg.go.dev/vuln/GO-2024-3023
https://pkg.go.dev/vuln/GO-2024-3022
https://pkg.go.dev/vuln/GO-2024-3020
https://pkg.go.dev/vuln/GO-2024-2958
https://pkg.go.dev/vuln/GO-2024-2707
https://pkg.go.dev/vuln/GO-2024-2706
https://pkg.go.dev/vuln/GO-2024-2696
https://pkg.go.dev/vuln/GO-2024-2695
https://pkg.go.dev/vuln/GO-2024-2687
https://pkg.go.dev/vuln/GO-2024-2635
https://pkg.go.dev/vuln/GO-2024-2595
https://pkg.go.dev/vuln/GO-2024-2594
https://pkg.go.dev/vuln/GO-2024-2593
https://pkg.go.dev/vuln/GO-2024-2592
https://pkg.go.dev/vuln/GO-2024-2591
https://pkg.go.dev/vuln/GO-2024-2590
https://pkg.go.dev/vuln/GO-2024-2589
https://pkg.go.dev/vuln/GO-2024-2588
https://pkg.go.dev/vuln/GO-2024-2566
https://pkg.go.dev/vuln/GO-2024-2541
https://pkg.go.dev/vuln/GO-2024-2450
https://pkg.go.dev/vuln/GO-2024-2448
https://pkg.go.dev/vuln/GO-2024-2446
https://pkg.go.dev/vuln/GO-2024-2444
https://pkg.go.dev/vuln/GO-2023-2402
https://pkg.go.dev/vuln/GO-2023-2074
https://pkg.go.dev/vuln/GO-2023-1571

There wasn't a release in over a year, but dependencies were recently updated on main.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the changes and upstream issues this "bump" looks OK.

The only breaking change I spotted is the removal of Gitter specific support since they moved to Matrix, the rest of the changes are bugfixes /dep upgrades.

42wim/matterbridge@6dafebc...c4157a4
42wim/matterbridge#2182

The package builds, I will try to test some bridges.

Result of nixpkgs-review pr 338232 run on x86_64-linux 1

1 package built:
  • matterbridge

Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some tests (mainly from and to Mattermost) and it seems fine.

@LeSuisse LeSuisse merged commit be7d7ef into NixOS:master Sep 15, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants